Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step: Step.Group with unstackable prop generates incorrect classname #1942

Closed
aert opened this issue Aug 7, 2017 · 4 comments · Fixed by #1943
Closed

Step: Step.Group with unstackable prop generates incorrect classname #1942

aert opened this issue Aug 7, 2017 · 4 comments · Fixed by #1943
Labels
bug

Comments

@aert
Copy link

aert commented Aug 7, 2017

Just a small typo in the Step component : an invalid comma is added to the generated html class for unstackable
The issue is here:

Semantic-UI-React/src/elements/Step/StepGroup.js

Line 38 in dc403d0

useKeyOnly(unstackable, 'unstackable,'),

Steps

  1. Run <Step.Group unstackable />

Expected Result

In generated html : class="unstackable"

Actual Result

In generated html : class="unstackable**,**"

Version

0.71.3

Testcase
@layershifter
Copy link
Member

@aert Thanks for report. PR for this will be awesome 👍

@layershifter layershifter changed the title Steps.Group with unstackable attribute generates incorrect classname Step: Step.Group with unstackable prop generates incorrect classname Aug 7, 2017
Joel-Raju added a commit to Joel-Raju/Semantic-UI-React that referenced this issue Aug 7, 2017
@Joel-Raju
fix(typo): fixed typo in Step component (Semantic-Org#1942)
3c9d888 
fixed typo of invalid comma for the generated class unstackable
@Joel-Raju
Copy link
Contributor

submitted a PR

@aert
Copy link
Author

aert commented Aug 7, 2017

Thank you @Joel-Raju

@aert
Copy link
Author

aert commented Aug 7, 2017

Thanks to you @layerfixer

@Joel-Raju Joel-Raju mentioned this issue Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Step): fixed typo in Step.Group className Joel-Raju/Semantic-UI-React
3 participants
@aert @Joel-Raju @layershifter