Skip to content

Commit

Permalink
feat(Message): add top to possible values of attached (#2197)
Browse files Browse the repository at this point in the history
  • Loading branch information
layershifter authored Oct 14, 2017
1 parent 70985ae commit c276f35
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/app/Layouts/AttachedContentLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const AttachedContentLayout = () => (
</Grid.Column>

<Grid.Column>
<Table attached='top' basic verticalAllign='top'>
<Table attached='top' basic verticalAlign='top'>
<Table.Header>
<Table.HeaderCell>Header</Table.HeaderCell>
<Table.HeaderCell>Header</Table.HeaderCell>
Expand Down
2 changes: 1 addition & 1 deletion src/collections/Message/Message.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface MessageProps {
as?: any;

/** A message can be formatted to attach itself to other content. */
attached?: boolean | 'bottom';
attached?: boolean | 'bottom' | 'top';

/** Primary content. */
children?: React.ReactNode;
Expand Down
2 changes: 1 addition & 1 deletion src/collections/Message/Message.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class Message extends Component {
/** A message can be formatted to attach itself to other content. */
attached: PropTypes.oneOfType([
PropTypes.bool,
PropTypes.oneOf(['bottom']),
PropTypes.oneOf(['bottom', 'top']),
]),

/** Primary content. */
Expand Down
2 changes: 1 addition & 1 deletion test/specs/collections/Message/Message-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Message', () => {
common.propKeyOnlyToClassName(Message, 'visible')
common.propKeyOnlyToClassName(Message, 'warning')

common.propKeyOrValueAndKeyToClassName(Message, 'attached', ['bottom'])
common.propKeyOrValueAndKeyToClassName(Message, 'attached', ['bottom', 'top'])

common.propValueOnlyToClassName(Message, 'color', SUI.COLORS)
common.propValueOnlyToClassName(Message, 'size', _.without(SUI.SIZES, 'medium'))
Expand Down

0 comments on commit c276f35

Please sign in to comment.