Merge pull request #143 from SelfhostedPro/develop

Hotfix
SelfhostedPro · Oct 3, 2020 · 7088754 · 7088754
2 parents 7a5efb4 + d14c171
commit 7088754
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/backend/api/actions/apps.py b/backend/api/actions/apps.py
@@ -28,8 +28,9 @@ def check_app_updates():
     dclient = docker.from_env()
     apps = dclient.containers.list(all=True)
     for app in apps:
-        if check_updates(app.image.tags[0]):
-            apps_list.append(app.name)
+        if app.attrs['Config']['Image']:
+            if check_updates(app.attrs['Config']['Image']):
+                apps_list.append(app.name)
     return apps_list
 
 def get_apps():

diff --git a/backend/api/utils.py b/backend/api/utils.py
@@ -11,6 +11,7 @@
 from .settings import Settings
 import aiodocker
 import docker
+from docker.errors import APIError
 import json
 settings = Settings()
 
@@ -361,7 +362,10 @@ def check_updates(tag):
     if tag:
         dclient = docker.from_env()
         current = dclient.images.get(tag)
-        new = dclient.images.get_registry_data(tag)
+        try:
+            new = dclient.images.get_registry_data(tag)
+        except APIError as err:
+            return False
         if new.attrs['Descriptor']['digest'] in current.attrs['RepoDigests'][0]:
             return False
         else: