Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Added instructions for Java in the 'Test Runners' section #1458

Merged
merged 4 commits into from
Aug 24, 2023
Merged

[Docs] Added instructions for Java in the 'Test Runners' section #1458

merged 4 commits into from
Aug 24, 2023

Conversation

Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Aug 18, 2023 •
edited
Loading

Fixes #1457

Description

This PR adds instructions to setup JUnit 5 as a test runner for Java.

Motivation and Context

There are currently no instructions for Java. So, I've included it.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Aug 18, 2023 •
edited
Loading

✅ Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 19950fb
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/64e749091dfa1c000838c13f
😎 Deploy Preview https://deploy-preview-1458--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Tahanima
Copy link
Contributor Author

@titusfortner, the 2 failures are unrelated to my PR.

@diemol
Copy link
Member

diemol commented Aug 23, 2023

Can you please add the same for the other first_script.*.md files?

@Tahanima
Copy link
Contributor Author

Can you please add the same for the other first_script.*.md files?

Sure, I will.

@Tahanima
Copy link
Contributor Author

@diemol I've added the same changes for the other first_script.*.md files.

diemol
diemol approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @Tahanima!

@diemol diemol merged commit 7a15a97 into SeleniumHQ:trunk Aug 24, 2023
7 checks passed
@Tahanima
Copy link
Contributor Author

Great, thank you @Tahanima!

You're welcome @diemol

@Tahanima Tahanima deleted the feature/add-content-in-test-runners-java branch August 24, 2023 12:18
selenium-ci added a commit that referenced this pull request Aug 24, 2023
@selenium-ci
[Docs] Added instructions for Java in the 'Test Runners' section (#1458)
cfec483 
* docs: added test runner instructions for java

Fixes #1457

* docs: added test runner instructions for java

---------

Co-authored-by: Diego Molina <[email protected]>

[deploy site] 7a15a97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Add instructions for Java in the 'Test Runners' section
3 participants
@Tahanima @CLAassistant @diemol