Repository navigation
[dotnet] [test] Entry point to mutate driver options per fixture - #18141
Merged
nvborisenko merged 2 commits intoOct 8, 2026
Merged
nvborisenko merged 2 commits into
nvborisenko merged 2 commits into
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid global driver options. Now any test fixture is able to customize it.
🔗 Related Issues
Improve internal testing.
💥 What does this PR do?
This pull request refactors how driver options are configured and passed throughout the test framework, replacing event-based customization with explicit configuration via delegates. It removes the
DriverStartingEventArgsclass and related event, and introduces a newConfigureDriverOptionsvirtual method pattern for greater flexibility and clarity. Several test fixtures are updated to use this new pattern, simplifying driver setup and making option customization more consistent.Driver customization refactor:
DriverStartingEventArgsclass and theDriverStartingevent fromDriverFactory, eliminating the event-based driver customization mechanism. [1] [2]DriverFactory.CreateDriverto accept aconfigureOptionsdelegate, which is invoked to customizeDriverOptionsbefore driver creation. [1] [2]DriverTestFixture,BiDiTestFixture,DownloadsTests,ProxySettingTests) to override or use the newConfigureDriverOptionsmethod for driver option customization, replacing previous event handler or custom options class patterns. [1] [2] [3] [4]Test code simplification and cleanup:
BiDiEnabledDriverOptions,DownloadableFilesOptions) and replaced them with direct configuration via the new delegate pattern. [1] [2]CreateDriverInstanceinstead of instantiating specific options classes.Test-specific driver configuration improvements:
ConfigureDriverOptions. [1] [2] [3]These changes improve maintainability and extensibility by making driver option customization more explicit and less reliant on events or custom types.
🤖 AI assistance
🔄 Types of changes