Skip to content

[build] remove bazel patches that now have upstream fixes - #18140

Merged
titusfortner merged 1 commit into
SeleniumHQ:trunkfrom
titusfortner:drop-upstreamed-bazel-patches
Oct 8, 2026
Merged

titusfortner merged 1 commit into
SeleniumHQ:trunkfrom
titusfortner:drop-upstreamed-bazel-patches

Conversation

@titusfortner

Copy link
Copy Markdown
Member

🔗 Related Issues

💥 What does this PR do?

  • Bumps bazel package versions and removes the local patches they make redundant

🔧 Implementation Notes

  • Bumps rules_ruby to 0.29.0, rules_jvm_external to 7.1, rules_rs to 0.1.0, and aspect_rules_jest to 0.26.0

🤖 AI assistance

  • AI assisted (complete below)
    • Tool(s): Claude Code (Fable 5.1)
    • What was generated: the upstream merge/release audit, the bumps, and this description
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

  • There are 2 more patches waiting on upstream merges/releases

🔄 Types of changes

  • Cleanup (dependency bumps, no user-facing behavior change)

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 8, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Bump Bazel rules and remove four upstreamed patches

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Bump Jest, JVM, Ruby, and Rust Bazel rules to releases containing local fixes.
• Remove four redundant patches while retaining overrides for fixes not yet available upstream.
Diagram

graph TD
  M["MODULE.bazel"] --> U["Four rule releases"] --> R["Redundant patches removed"]
  M --> O["Remaining overrides"] --> P["Local patches"]
Loading
High-Level Assessment

Upgrading to releases with the needed fixes is preferable to carrying duplicate local patches. Keeping the remaining overrides preserves fixes that cannot yet be dropped; retaining all patches would add maintenance without a clear benefit.

Files changed (1) +6 / -25

Other (1) +6 / -25
MODULE.bazelBump four Bazel rules and remove redundant patch references +6/-25

Bump four Bazel rules and remove redundant patch references

• Pins aspect_rules_jest to 0.26.0, rules_jvm_external to 7.1, rules_ruby to 0.29.0, and rules_rs to 0.1.0. Removes references to four now-redundant patches, including the Rust module-extension patch, while retaining and clarifying the overrides still needed.

MODULE.bazel

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@titusfortner titusfortner changed the title [build] bump rules_ruby, rules_jvm_external, rules_rs, and rules_jest to drop patches that landed upstream [build] remove bazel patches that now have upstream fixes Oct 8, 2026
@titusfortner
titusfortner merged commit 42ee793 into SeleniumHQ:trunk Oct 8, 2026
55 checks passed
This was referenced Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants