Skip to content

[dotnet] [build] Escape macOS Edge browser path - #18126

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-bazel-edge
Oct 5, 2026
Merged

nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-bazel-edge

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

🔗 Related Issues

bazel test //dotnet/test/webdriver:VisibilityTests-edge fails.

💥 What does this PR do?

This pull request makes a minor fix to the path for the Edge browser in the _BROWSERS configuration within the dotnet_nunit_test_suite.bzl file. The change ensures that the space in the "Microsoft Edge" application name is properly escaped, which is important for correct path resolution in scripts.

  • Fixed the BrowserLocation path for Edge on macOS by escaping the space in "Microsoft Edge" (dotnet/private/dotnet_nunit_test_suite.bzl).

🔧 Implementation Notes

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added C-dotnet .NET Bindings B-build Includes scripting, bazel and CI integrations labels Oct 5, 2026
@nvborisenko
nvborisenko merged commit 9fc36cc into SeleniumHQ:trunk Oct 5, 2026
30 checks passed
@nvborisenko
nvborisenko deleted the dotnet-bazel-edge branch October 5, 2026 19:01
This was referenced Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants