[py] remove stale xfail markers from python tests - #18002
Merged
diemol merged 4 commits intoSep 8, 2026
Conversation
The xfail_edge markers on the window size/position tests were added in SeleniumHQ#15638 without a reason or linked issue, and the xfail_chrome, xfail_firefox and xfail_remote markers next to them cite a geckodriver window-positioning bug that no longer reproduces on CI. With all of these markers removed, window_tests.py and api_example_tests.py pass on chrome, firefox and edge on Windows and on chrome and firefox through a Grid on Linux, across several runs. The Edge tests also pass locally on macOS. The xfail_safari markers are untouched, as are the markers on the two logging tests, which still raise AttributeError outside Chromium.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
|
navin772
approved these changes
Sep 8, 2026
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
💥 What does this PR do?
This PR removes the stale xfail markers for -
window_tests.py,api_example_tests.py.The xfail_safari markers are untouched, as are the markers on the two logging tests, which still raise AttributeError outside Chromium.
🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes