[dotnet] [bidi] Avoid massive command descriptors allocation - #17965
Merged
nvborisenko merged 1 commit intoAug 28, 2026
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes .NET BiDi module initialization by passing command metadata directly to the broker instead of eagerly creating static descriptors.
Changes:
- Replaces static command descriptors with inline method and JSON metadata.
- Refactors
ModuleandBrokercommand execution APIs. - Updates the custom-module test; however, the public API removal lacks deprecation compatibility.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
dotnet/test/webdriver/BiDi/Session/SessionTests.cs |
Updates custom-module command execution. |
dotnet/src/webdriver/BiDi/WebExtension/WebExtensionModule.cs |
Inlines WebExtension metadata. |
dotnet/src/webdriver/BiDi/Storage/StorageModule.cs |
Inlines Storage metadata. |
dotnet/src/webdriver/BiDi/Session/SessionModule.cs |
Inlines Session metadata. |
dotnet/src/webdriver/BiDi/Script/ScriptModule.cs |
Inlines Script metadata. |
dotnet/src/webdriver/BiDi/Permissions/PermissionsModule.cs |
Inlines Permissions metadata. |
dotnet/src/webdriver/BiDi/Network/NetworkModule.cs |
Removes eagerly initialized Network descriptors. |
dotnet/src/webdriver/BiDi/Module.cs |
Changes the protected execution API. |
dotnet/src/webdriver/BiDi/Input/InputModule.cs |
Inlines Input metadata. |
dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs |
Inlines Emulation metadata. |
dotnet/src/webdriver/BiDi/Command.cs |
Removes the public command descriptor type. |
dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextModule.cs |
Inlines browsing-context metadata. |
dotnet/src/webdriver/BiDi/Browser/BrowserModule.cs |
Inlines Browser metadata. |
dotnet/src/webdriver/BiDi/Broker.cs |
Accepts flattened command metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Good improvement, thanks. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance.
🔗 Related Issues
When we access
bidi.Networkthen all commands are statically allocated. We can do better.💥 What does this PR do?
Inline necessary commands info at caller side without any allocations.
🤖 AI assistance
🔄 Types of changes