Honour the DO_NOT_TRACK env var

[shs96c]

Rather than having multiple different mechanisms per app for handling opting out of tracking, there's a move to standardise on this env var (https://donottrack.sh/) Selenium should honour that.

[qodo-code-review]

PR Summary by Qodo

Honor DO_NOT_TRACK for Selenium Manager telemetry

✨ Enhancement 🧪 Tests 🕐 Less than 10 minutes

AI Description

• Honor DO_NOT_TRACK=1 by disabling Selenium Manager usage statistics.
• Preserve existing opt-out behavior and test accepted and ignored environment values.

Diagram

graph TD
  DNT["DO_NOT_TRACK"] --> Resolve["Opt-out resolver"] --> Config["Manager config"] --> Gate{"Stats allowed?"} -->|Yes| Stats["Plausible stats"]
  Existing["Existing opt-out"] --> Resolve
  Gate -->|No| Skip["Skip telemetry"]

Loading

High-Level Assessment

The centralized configuration approach is appropriate: it combines DO_NOT_TRACK with the existing opt-out without weakening either mechanism, and the pure helper makes the precedence rule easy to test. Reading the variable directly in the telemetry sender was considered but would scatter tracking policy outside configuration initialization.

Files changed (1) +31 / -1

Enhancement (1) +31 / -1

config.rsRespect DO_NOT_TRACK when resolving telemetry configuration +31/-1

Respect DO_NOT_TRACK when resolving telemetry configuration

• Adds 'DO_NOT_TRACK=1' as an additional condition for setting 'ManagerConfig::avoid_stats', while preserving the existing configuration and feature-based opt-out. Adds focused unit tests for the supported value, the existing opt-out, and ignored values.

rust/src/config.rs

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[cgoldberg]

nice.. I already have that set in my shell config :)