[build] Upgrade rules_rs to 0.0.109 and @llvm to 0.8.19 - #17929
Merged
Conversation
2 tasks
This was referenced Sep 5, 2026
AutomatedTester
force-pushed
the
rules-bump-0.0.106
branch
from
September 8, 2026 11:03
593782c to
9095598
Compare
AutomatedTester
force-pushed
the
rules-bump-0.0.106
branch
from
September 8, 2026 12:02
9095598 to
9cf675b
Compare
Member
|
Sorry, I jumped over you on this one with #17997 and didn't close this. It needed a patch, and I PR'd the fix upstream as well. |
Member
|
Oh, I missed that there's a 109. Good times. I'll look at what it adds. |
This was referenced Sep 9, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Rust build toolchain to current releases:
rules_rs0.0.96 → 0.0.109 (this also advances the vendoredrules_rustfork it bundles, commitb03f1b0→e9dd49f)@llvm(hermetic-llvm) 0.8.11 → 0.8.19 (LLVM 23.1.0)Dropped local patch
rules_rs0.0.109 carries the zlib snapshot-URL fix upstream (itsrustc_repository.bzlnow points atsnapshot.ubuntu.com), so the localrules_rs_zlib_snapshot.patchand itssingle_version_overrideare removed —matching the existing "remove when updating to rules_rs >= 0.0.108" note.
Required API change
The
rules_rstoolchains module extension no longer publishes a top-level:alltarget for the generated toolchains repo, so registration uses therecursive pattern:
Validation
bazel build //rust:selenium-manager -c optbuilds cleanly on macOS (arm64);the resulting binary runs (
selenium-manager 0.4.49-nightly)../scripts/format.sh --pre-pushpasses.Notes
selenium-managerbinaries are Cargo-built in CI; this changeaffects the Bazel (local/dev) build path only.
@llvm0.8.18 already added Windowscc_commonlinking and authoritativeWindows ABI handling, and
rules_rsexposes a configurabledeclare_rustc_toolchainsmacro — relevant groundwork for the in-progressWindows-host build of
selenium-manager([rust] Allow cross-compilation of selenium-manager on all platforms #17586), but not exercised here.