[rb] add low-level BiDi protocol integration specs

.github/workflows/ci-ruby.yml

@@ -91,7 +91,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows]
-        tag_filters: [chrome-beta, firefox-beta, edge-local]
+        tag_filters: [chrome-beta, firefox-beta, "edge-local,edge-bidi"]
         include:
           - os: macos
             tag_filters: safari-local,safari-preview-bidi

rb/lib/selenium/webdriver/bidi/error.rb

@@ -23,6 +23,10 @@
 module Selenium
   module WebDriver
     module Error
+      # Raised locally when a BiDi wire payload does not match this Selenium's generated
+      # schema. It is not a protocol error code; the (de)serialization layer raises it directly.
+      class SerializationError < WebDriverError; end
+
       # Register each BiDi-only code as a WebDriverError subclass; shared codes keep their classic class.
       BiDi::Protocol::ErrorCode::CLASS_NAMES.each_value do |name|
         const_set(name, Class.new(WebDriverError)) unless const_defined?(name, false)

rb/lib/selenium/webdriver/bidi/serialization.rb

@@ -79,7 +79,7 @@ def self.to_symbol(name, value, enum)
           return value if value.nil?
           return value.map { |element| to_symbol(name, element, enum) } if value.is_a?(::Array)
 
-          enum.key(value) || raise(Error::WebDriverError, "#{name} received an unknown value: #{value.inspect}")
+          enum.key(value) || raise(Error::SerializationError, "#{name} received an unknown value: #{value.inspect}")
         end
       end
     end # BiDi

rb/lib/selenium/webdriver/bidi/serialization/record.rb

@@ -85,7 +85,7 @@ def new(**kwargs)
             # (extensible) or warned and dropped (closed) — strict on shape, lenient on extras.
             def from_json(json_payload)
               unless json_payload.is_a?(::Hash)
-                raise Error::WebDriverError, "#{name} expected an object on the wire, got #{json_payload.inspect}"
+                raise Error::SerializationError, "#{name} expected an object on the wire, got #{json_payload.inspect}"
               end
 
               attributes = fields.to_h do |f|
@@ -228,7 +228,7 @@ def wire_value(field, json_payload)
             # which matters for the required-and-nullable fields the schema flags.
             def missing_required(field)
               message = "#{name}##{field.name} is required but was missing from the response"
-              raise Error::WebDriverError, message if Serialization.strict?
+              raise Error::SerializationError, message if Serialization.strict?
 
               WebDriver.logger.warn(message, id: :bidi_missing_required)
               UNSET
@@ -238,7 +238,7 @@ def read(field, raw)
               if raw.nil?
                 return raw if field.nullable
 
-                raise Error::WebDriverError, "#{name}##{field.name} received null but is not nullable"
+                raise Error::SerializationError, "#{name}##{field.name} received null but is not nullable"
               end
               check_shape(field, raw)
               return Serialization.to_symbol("#{name}##{field.name}", raw, enum_hash(field)) if field.enum
@@ -268,7 +268,7 @@ def check_shape(field, raw)
               return if field.list == raw.is_a?(::Array)
               return unless field.list || field.enum || field.ref
 
-              raise Error::WebDriverError,
+              raise Error::SerializationError,
                     "#{name}##{field.name} expected #{field.list ? 'a list' : 'a single value'}, got #{raw.inspect}"
             end
 
@@ -285,7 +285,7 @@ def check_primitive(field, raw)
               expected = PRIMITIVE_TYPES[field.primitive]
               return if expected.nil? || expected.any? { |type| raw.is_a?(type) }
 
-              raise Error::WebDriverError, "#{name}##{field.name} expected #{field.primitive}, got #{raw.inspect}"
+              raise Error::SerializationError, "#{name}##{field.name} expected #{field.primitive}, got #{raw.inspect}"
             end
 
             def enum_hash(field)
@@ -314,7 +314,7 @@ def read_list(field, raw, klass)
             # malformed entry and is rejected outright.
             def read_map_entry(field, element, klass)
               unless element.is_a?(::Array) && element.size == 2
-                raise Error::WebDriverError,
+                raise Error::SerializationError,
                       "#{name}##{field.name} expected a [key, value] pair, got #{element.inspect}"
               end
 
@@ -332,7 +332,7 @@ def scalar_value(field, value)
               expected = Array(field.scalar).flat_map { |primitive| PRIMITIVE_TYPES[primitive] || [] }
               return value if expected.empty? || expected.any? { |type| value.is_a?(type) }
 
-              raise Error::WebDriverError,
+              raise Error::SerializationError,
                     "#{name}##{field.name} expected #{Array(field.scalar).join(' or ')}, got #{value.inspect}"
             end
 

rb/lib/selenium/webdriver/bidi/serialization/union.rb

@@ -60,12 +60,12 @@ def from_json(json_payload)
               unless json_payload.is_a?(::Hash)
                 return json_payload unless @object_only
 
-                raise Error::WebDriverError, "#{name} expected an object on the wire, got #{json_payload.inspect}"
+                raise Error::SerializationError, "#{name} expected an object on the wire, got #{json_payload.inspect}"
               end
 
               variant = select(json_payload)
               unless variant
-                raise Error::WebDriverError,
+                raise Error::SerializationError,
                       "#{name} received a variant not in this Selenium's BiDi schema: #{json_payload.inspect}"
               end
               Protocol.const_get(variant).from_json(json_payload)

rb/spec/BUILD.bazel

@@ -18,6 +18,7 @@ rb_library(
         "//rb/spec/integration:all_srcs",
         "//rb/spec/integration/selenium/webdriver:all_srcs",
         "//rb/spec/integration/selenium/webdriver/bidi:all_srcs",
+        "//rb/spec/integration/selenium/webdriver/bidi/protocol:all_srcs",
         "//rb/spec/integration/selenium/webdriver/chrome:all_srcs",
         "//rb/spec/integration/selenium/webdriver/edge:all_srcs",
         "//rb/spec/integration/selenium/webdriver/firefox:all_srcs",

rb/spec/integration/selenium/webdriver/bidi/protocol/BUILD.bazel

@@ -0,0 +1,23 @@
+load("//rb/spec:tests.bzl", "rb_integration_test")
+
+filegroup(
+    name = "all_srcs",
+    testonly = True,
+    srcs = glob(["*.rb"]),
+    visibility = ["//rb/spec:__pkg__"],
+)
+
+[
+    rb_integration_test(
+        name = file[:-8],
+        srcs = [file],
+        bidi = True,
+        classic = False,
+        data = ["//common/extensions"],
+        tags = ["exclusive-if-local"],
+        deps = [
+            "//rb/lib/selenium/webdriver:bidi",
+        ],
+    )
+    for file in glob(["*_spec.rb"])
+]