-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Add transport layer that will be used by generated BiDi Modules #17758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2dd6948
[java] Move BiDi creation to RemoteWebDriver. Add enable BiDi to Safa…
pujagani 4f2e639
Address code comments
pujagani b045455
Fix code comments
pujagani bddc2a0
Avoid httpclient leaks on failed connection
pujagani 1f644c1
Address comments
pujagani 27b6142
[java][bidi] Add transport seam to be used by generated BiDi modules
pujagani 387acc8
Avoid unrelated changea
pujagani 6d114f7
Fix code comments
pujagani 1360947
Address comments
pujagani ffe777f
Add comments
pujagani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.openqa.selenium.bidi; | ||
|
|
||
| import java.util.function.Consumer; | ||
| import org.openqa.selenium.Beta; | ||
|
|
||
| /** | ||
| * An opaque handle to the active BiDi connection, used by {@link Module} subclasses to send | ||
| * commands and subscribe to events. | ||
| * | ||
| * <p>Constructor and all methods are package-private: external callers that hold a {@code Handle} | ||
| * reference cannot invoke it, only pass it to module constructors inside this package. Create an | ||
| * instance via {@link BiDi#asHandle()}. | ||
| */ | ||
| @Beta | ||
| public class Handle { | ||
|
|
||
| private final BiDi bidi; | ||
|
|
||
| Handle(BiDi bidi) { | ||
| this.bidi = bidi; | ||
| } | ||
|
|
||
| <X> X send(Command<X> command) { | ||
| return bidi.send(command); | ||
| } | ||
|
|
||
| <X> String subscribe(Event<X> event, Consumer<X> handler) { | ||
| return bidi.addListener(event, handler); | ||
| } | ||
|
pujagani marked this conversation as resolved.
|
||
|
|
||
| void unsubscribe(String subscriptionId) { | ||
| bidi.removeListener(subscriptionId); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.openqa.selenium.bidi; | ||
|
|
||
| import java.util.function.Consumer; | ||
| import org.openqa.selenium.Beta; | ||
| import org.openqa.selenium.WebDriver; | ||
| import org.openqa.selenium.internal.Require; | ||
|
|
||
| /** | ||
| * Base class for generated BiDi module classes. | ||
| * | ||
| * <p>Subclasses delegate all wire operations through the driver's shared {@link Handle} — no new | ||
| * WebSocket connection is opened. | ||
| */ | ||
| @Beta | ||
| public abstract class Module { | ||
|
|
||
| private final Handle handle; | ||
|
|
||
| protected Module(WebDriver driver) { | ||
| Require.nonNull("WebDriver", driver); | ||
| if (!(driver instanceof HasBiDi)) { | ||
| throw new BiDiException("WebDriver does not support BiDi protocol"); | ||
| } | ||
| this.handle = ((HasBiDi) driver).getHandle(); | ||
| } | ||
|
|
||
| protected final <X> X send(Command<X> command) { | ||
| return handle.send(command); | ||
| } | ||
|
|
||
| protected final <X> String subscribe(Event<X> event, Consumer<X> handler) { | ||
| return handle.subscribe(event, handler); | ||
| } | ||
|
|
||
| protected final void unsubscribe(String subscriptionId) { | ||
| handle.unsubscribe(subscriptionId); | ||
| } | ||
|
pujagani marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.