Skip to content

[rust] Support multiple names for Firefox binary in Linux (#17695) #17732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonigarcia merged 4 commits into from
Jul 2, 2026
Merged

[rust] Support multiple names for Firefox binary in Linux (#17695) #17732

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1952e42
[rust] Support multiple names for Firefox binary in Linux (#17695)
bonigarcia Jun 30, 2026
eb2b83b
[rust] Fix additional browser names for Firefox unstable
bonigarcia Jul 1, 2026
70d00d1
[rust] Check avoid browser download flag
bonigarcia Jul 2, 2026
87bce21
Merge branch 'trunk' into sm_firefox_linux
bonigarcia Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion rust/src/firefox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,19 @@ impl SeleniumManager for FirefoxManager {
}

fn get_browser_names_in_path(&self) -> Vec<&str> {
vec![self.get_browser_name()]
let browser_version = self.get_browser_version();
let mut browser_names = vec![];
if self.is_beta(browser_version) {
browser_names.push("firefox-beta");
} else if self.is_dev(browser_version) {
browser_names.push("firefox-devedition");
} else if self.is_nightly(browser_version) {
browser_names.push("firefox-trunk");
} else if self.is_esr(browser_version) {
browser_names.push("firefox-esr");
}
browser_names.push(self.get_browser_name());
browser_names
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
}

fn get_http_client(&self) -> &Client {
Expand Down
Loading