Skip to content

[js] update dev dependencies#17479

Merged
titusfortner merged 1 commit into
trunkfrom
js_deps_bump
May 16, 2026
Merged

[js] update dev dependencies#17479
titusfortner merged 1 commit into
trunkfrom
js_deps_bump

Conversation

@titusfortner

Copy link
Copy Markdown
Member

Shouldn't have impact on user facing code. Straightforward to merge after tests pass.

@selenium-ci selenium-ci added the C-nodejs JavaScript Bindings label May 16, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update JavaScript dev dependencies to latest versions

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update ESLint plugins to latest versions with breaking changes
• Upgrade Express from v4 to v5 with major dependency updates
• Update Sinon testing library from v19 to v22
• Fix ESLint configuration for new plugin API requirements
• Update globals package and other dev dependencies
Diagram
flowchart LR
  A["Dev Dependencies"] --> B["ESLint Plugins"]
  A --> C["Express Framework"]
  A --> D["Testing Libraries"]
  B --> E["eslint-plugin-mocha v11"]
  B --> F["eslint-plugin-n v18"]
  C --> G["Express v5"]
  D --> H["Sinon v22"]
  D --> I["globals v17"]
  E --> J["Config Updates"]
  F --> J
  G --> K["Router Changes"]
Loading

Grey Divider

File Changes

1. javascript/selenium-webdriver/eslint.config.js ⚙️ Configuration changes +5/-5

Update ESLint configuration for new plugin versions

• Update ESLint plugin imports to use .default exports for mocha and node plugins
• Change mocha plugin config from flat.recommended to recommended
• Remove deprecated mocha/no-skipped-tests rule
• Replace mocha/no-empty-description with mocha/no-empty-title
• Add new mocha/no-async-suite rule configuration

javascript/selenium-webdriver/eslint.config.js


2. javascript/selenium-webdriver/lib/test/fileserver.js 🐞 Bug fix +1/-1

Fix Express v5 route parameter naming

• Add named parameter path to Express route handler for Path.PAGE + '/*'
• Ensures proper parameter capture in Express v5 routing

javascript/selenium-webdriver/lib/test/fileserver.js


3. javascript/selenium-webdriver/package.json Dependencies +5/-5

Update major dev dependency versions

• Bump eslint-plugin-mocha from v10.5.0 to v11.2.0
• Bump eslint-plugin-n from v17.24.0 to v18.0.1
• Upgrade Express from v4.22.2 to v5.2.1 (major version)
• Upgrade globals from v15.15.0 to v17.6.0
• Upgrade Sinon from v19.0.5 to v22.0.0 (major version)

javascript/selenium-webdriver/package.json


View more (1)
4. pnpm-lock.yaml Dependencies +199/-189

Update dependency lock file for all version changes

• Update lock file with new versions of all bumped dependencies
• Add new transitive dependencies for Express v5 (router, new body-parser, etc.)
• Update Sinon v22 dependencies (@sinonjs/fake-timers, @sinonjs/samsam)
• Remove obsolete dependencies (array-flatten, destroy, methods, utils-merge)
• Add new versions of content negotiation and HTTP utilities

pnpm-lock.yaml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@titusfortner titusfortner merged commit 6e3c90b into trunk May 16, 2026
29 checks passed
@titusfortner titusfortner deleted the js_deps_bump branch May 16, 2026 13:05
This was referenced Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-nodejs JavaScript Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants