Skip to content

[build] fix when to update lock files during the release process #17450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 2 commits into from
May 13, 2026
+26 −8
Merged

[build] fix when to update lock files during the release process #17450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c4924
[build] fix when to update lock files during the release process
titusfortner May 13, 2026
245d8a8
add the rust update command to local release_updates task
titusfortner May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,31 @@ jobs:
secrets:
SELENIUM_CI_TOKEN: ${{ secrets.SELENIUM_CI_TOKEN }}

reset-dependencies:
name: Update Lockfiles for Nightly
needs: [parse-tag, update-version]
uses: ./.github/workflows/bazel.yml
with:
name: Reset Dependencies
run: ./go ${{ needs.parse-tag.outputs.language }}:update${{ needs.parse-tag.outputs.language == 'all' && ' && ./go rust:update' || '' }}
Comment thread
titusfortner marked this conversation as resolved.
artifact-name: version-reset-deps

Comment thread
titusfortner marked this conversation as resolved.
commit-dependencies:
name: Push Nightly Lockfiles
needs: [parse-tag, reset-dependencies]
permissions:
contents: write
actions: read
uses: ./.github/workflows/commit-changes.yml
with:
artifact-name: version-reset-deps
commit-message: "[build] Update lockfiles for nightly versions"
secrets:
SELENIUM_CI_TOKEN: ${{ secrets.SELENIUM_CI_TOKEN }}

nightly:
name: Publish Nightly Packages
needs: [parse-tag, update-version]
needs: [parse-tag, commit-dependencies]
permissions:
contents: write
packages: write
Expand All @@ -293,7 +315,7 @@ jobs:
on-release-failure:
name: On Release Failure
runs-on: ubuntu-latest
needs: [publish, publish-python, docs, create-language-tag, github-release-draft, github-release-publish, update-version, nightly, mirror, verify]
needs: [publish, publish-python, docs, create-language-tag, github-release-draft, github-release-publish, update-version, reset-dependencies, commit-dependencies, nightly, mirror, verify]
if: failure()
steps:
- uses: actions/checkout@v4
Expand All @@ -313,6 +335,7 @@ jobs:
• Docs Updated: ${{ needs.docs.result }}
• GitHub Release Published: ${{ needs.github-release-publish.result }}
• Nightly Version Updated: ${{ needs.update-version.result }}
• Nightly Lockfiles Updated: ${{ needs.commit-dependencies.result }}
• Nightly Packages: ${{ needs.nightly.result }}
• Mirror Updated: ${{ needs.mirror.result }}
• Packages Verified: ${{ needs.verify.result }}
Expand Down
1 change: 1 addition & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ task :release_updates, [:tag, :channel] do |_task, arguments|
Rake::Task['update_multitool'].invoke
Rake::Task['authors'].invoke
Rake::Task['rust:version'].invoke(version)
Rake::Task['rust:update'].invoke
Rake::Task['rust:changelogs'].invoke
end

Expand Down
6 changes: 0 additions & 6 deletions rake_tasks/rust.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,4 @@ task :version, [:version] do |_task, arguments|
text = File.read(file).sub(pattern, "\\1#{new_version}\\2")
File.open(file, 'w') { |f| f.puts text }
end
Comment thread
titusfortner marked this conversation as resolved.

# Rake::Task#invoke is a no-op if the task has already run in this process
# (e.g. when chaining `./go rust:version X && ./go rust:version nightly`),
# so reenable before invoking to ensure Cargo.lock is refreshed every time.
Rake::Task['rust:update'].reenable
Rake::Task['rust:update'].invoke
end
Loading