Skip to content

[dotnet] [test] Unignore network conditions tests for Firefox#17386

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-unignore-networkconditions-tests
Apr 24, 2026
Merged

[dotnet] [test] Unignore network conditions tests for Firefox#17386
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-unignore-networkconditions-tests

Conversation

@nvborisenko
Copy link
Copy Markdown
Member

Seems it can be unignored.

💥 What does this PR do?

This pull request removes the IgnoreBrowser attribute for Firefox from two tests in EmulationTests.cs, allowing these tests to run for Firefox as well. This suggests that Firefox may now support the tested features or the previous limitation has been resolved.

Test coverage improvements:

  • Removed the IgnoreBrowser(Infrastructure.Browser.Firefox, ...) attribute from CanSetNetworkConditionsOffline, enabling this test to run on Firefox.
  • Removed the IgnoreBrowser(Infrastructure.Browser.Firefox, ...) attribute from CanSetNetworkConditionsToDefault, enabling this test to run on Firefox.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • Cleanup (formatting, renaming)

Copilot AI review requested due to automatic review settings April 24, 2026 21:46
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Unignore network conditions tests for Firefox

🧪 Tests

Grey Divider

Walkthroughs

Description
• Remove Firefox ignore attributes from network condition tests
• Enable network condition tests to run on Firefox

Grey Divider

File Changes

1. dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs 🧪 Tests +0/-2

Remove Firefox ignore attributes from network tests

• Removed IgnoreBrowser(Infrastructure.Browser.Firefox, "Not supported yet?") attribute from
 CanSetNetworkConditionsOffline test
• Removed IgnoreBrowser(Infrastructure.Browser.Firefox, "Not supported yet?") attribute from
 CanSetNetworkConditionsToDefault test
• Enables both network condition tests to execute on Firefox browser

dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Apr 24, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (2) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. CanSetNetworkConditionsOffline ungated 📘 Rule violation ☼ Reliability
Description
The Firefox-specific gating for this BiDi emulation integration test was removed, so it now runs
unconditionally without any feature/driver-support check. This can cause CI failures in environments
where Firefox/WebDriver does not support setting network conditions.
Code

dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[254]

-    [IgnoreBrowser(Infrastructure.Browser.Firefox, "Not supported yet?")]
Evidence
PR Compliance ID 11 requires integration tests to be gated based on feature/driver support. The
CanSetNetworkConditionsOffline test now has no IgnoreBrowser (or alternative capability-based
guard) and will execute on Firefox as part of the test suite.

dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[253-261]
Best Practice: Learned patterns

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A previously Firefox-gated integration test now runs on Firefox without checking whether `bidi.Emulation.SetNetworkConditionsAsync` is supported.

## Issue Context
Compliance requires integration tests to be conditionally executed based on feature/driver support to avoid cross-environment CI failures.

## Fix Focus Areas
- dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[253-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. CanSetNetworkConditionsToDefault ungated 📘 Rule violation ☼ Reliability
Description
The Firefox-specific gating for this BiDi emulation integration test was removed, so it now runs
unconditionally without any feature/driver-support check. This can cause CI failures in environments
where Firefox/WebDriver does not support resetting network conditions.
Code

dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[265]

-    [IgnoreBrowser(Infrastructure.Browser.Firefox, "Not supported yet?")]
Evidence
PR Compliance ID 11 requires integration tests to be gated based on feature/driver support. The
CanSetNetworkConditionsToDefault test now has no IgnoreBrowser (or alternative capability-based
guard) and will execute on Firefox as part of the test suite.

dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[263-271]
Best Practice: Learned patterns

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A previously Firefox-gated integration test now runs on Firefox without checking whether `bidi.Emulation.SetNetworkConditionsAsync` is supported.

## Issue Context
Compliance requires integration tests to be conditionally executed based on feature/driver support to avoid cross-environment CI failures.

## Fix Focus Areas
- dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs[263-271]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Firefox-specific ignores from two BiDi emulation network conditions tests so they run on Firefox as well, expanding cross-browser test coverage for the emulation.setNetworkConditions command.

Changes:

  • Unignored CanSetNetworkConditionsOffline for Firefox.
  • Unignored CanSetNetworkConditionsToDefault for Firefox.

@nvborisenko nvborisenko merged commit 2bfde62 into SeleniumHQ:trunk Apr 24, 2026
24 of 25 checks passed
@nvborisenko nvborisenko deleted the dotnet-unignore-networkconditions-tests branch April 24, 2026 22:06
This was referenced May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants