[dotnet] [test] Unignore network conditions tests for Firefox#17386
Conversation
Review Summary by QodoUnignore network conditions tests for Firefox
WalkthroughsDescription• Remove Firefox ignore attributes from network condition tests • Enable network condition tests to run on Firefox File Changes1. dotnet/test/webdriver/BiDi/Emulation/EmulationTests.cs
|
Code Review by Qodo
1. CanSetNetworkConditionsOffline ungated
|
There was a problem hiding this comment.
Pull request overview
Removes Firefox-specific ignores from two BiDi emulation network conditions tests so they run on Firefox as well, expanding cross-browser test coverage for the emulation.setNetworkConditions command.
Changes:
- Unignored
CanSetNetworkConditionsOfflinefor Firefox. - Unignored
CanSetNetworkConditionsToDefaultfor Firefox.
Seems it can be unignored.
💥 What does this PR do?
This pull request removes the
IgnoreBrowserattribute for Firefox from two tests inEmulationTests.cs, allowing these tests to run for Firefox as well. This suggests that Firefox may now support the tested features or the previous limitation has been resolved.Test coverage improvements:
IgnoreBrowser(Infrastructure.Browser.Firefox, ...)attribute fromCanSetNetworkConditionsOffline, enabling this test to run on Firefox.IgnoreBrowser(Infrastructure.Browser.Firefox, ...)attribute fromCanSetNetworkConditionsToDefault, enabling this test to run on Firefox.🤖 AI assistance
🔄 Types of changes