feat(py): extend create-bidi-src with full set of BiDi-adjacent CDDL … by AutomatedTester · Pull Request #17378 · SeleniumHQ/selenium

AutomatedTester · 2026-04-23T19:49:48Z

…specs

Include permissions, prefetch (speculation), ua-client-hints, and web-bluetooth all.cddl files from the webref_cddl_extension added in #17372. This gives end users the complete set of BiDi-adjacent modules generated from the W3C spec:

New modules: bluetooth, speculation, user_agent_client_hints AT Driver (interaction, settings) excluded for now — can be added when ready by including @at_driver_all_cddl and declaring those modules.

Changes:

generate_bidi.bzl: add extra_cddl_files attr; merge step using cat; declare new output modules
py/BUILD.bazel: wire up the four new _all_cddl targets
generate_bidi.py: remove hardcoded generate_permissions_file(); the permissions module is now fully driven by permissions-all.cddl
bidi_enhancements_manifest.py: add permissions enhancements restoring the high-level set_permission() API, including embeddedOrigin support that the old hardcoded version was missing

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

🤖 AI assistance

No substantial AI assistance used
AI assisted (complete below)
- Tool(s):
- What was generated:
- I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

New feature (non-breaking change which adds functionality and tests!)

Copilot

Pull request overview

Extends the Python BiDi code-generation pipeline to include additional “BiDi-adjacent” CDDL specs (permissions, prefetch/speculation, UA client hints, web-bluetooth) and restores higher-level permissions conveniences via the enhancements manifest.

Changes:

Adds extra_cddl_files support to the Bazel generate_bidi rule and merges multiple CDDL inputs before generation.
Wires additional *_all_cddl specs into the Python create-bidi-src generation target and declares new output modules.
Removes the hardcoded permissions module generation in generate_bidi.py and reintroduces set_permission() API behavior via bidi_enhancements_manifest.py.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`py/private/generate_bidi.bzl`	Adds `extra_cddl_files` and concatenates multiple CDDL inputs; updates declared module outputs.
`py/BUILD.bazel`	Wires additional downloaded CDDL specs into the `create-bidi-src` target.
`py/generate_bidi.py`	Removes the bespoke `generate_permissions_file()` generation path so permissions come from CDDL.
`py/private/bidi_enhancements_manifest.py`	Adds permissions enhancements (PermissionDescriptor + `set_permission()` helper) including embedded-origin support.

- generate_bidi.bzl: replace cat-based merge with a hermetic Python script written via ctx.actions.write + ctx.actions.run, fixing portability on Windows where cat is unavailable - bidi_enhancements_manifest.py: make embedded_origin keyword-only in set_permission() by moving it after user_context with a * separator, preserving the existing positional call signature (descriptor, state, origin, user_context) - bidi_permissions_tests.py: add two new tests: - test_embedded_origin_is_keyword_only: guards against regression of the positional API (4th arg must remain user_context, not embedded_origin) - test_can_set_permission_with_embedded_origin: exercises the embedded_origin keyword arg end-to-end, verifying embeddedOrigin serialization in the BiDi command params Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

- merge_cddl.py: add arg validation (usage + SystemExit(1) if < 2 args) and insert a newline separator between files to prevent token-joining - generate_bidi.bzl: make merge_tool optional (mandatory=False); add explicit fail() when extra_cddl_files is set without merge_tool - bidi_enhancements_manifest.py: drop spurious return from set_permission (annotated -> None, was returning execute() result) - bidi_permissions_tests.py: add pytest.raises(TypeError) for 5th positional arg in test_embedded_origin_is_keyword_only; fix test_can_set_permission_with_embedded_origin docstring to accurately describe what is tested Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…specs Include permissions, prefetch (speculation), ua-client-hints, and web-bluetooth all.cddl files from the webref_cddl_extension added in #17372. This gives end users the complete set of BiDi-adjacent modules generated from the W3C spec: New modules: bluetooth, speculation, user_agent_client_hints AT Driver (interaction, settings) excluded for now — can be added when ready by including @at_driver_all_cddl and declaring those modules. Changes: - generate_bidi.bzl: add extra_cddl_files attr; merge step using cat; declare new output modules - py/BUILD.bazel: wire up the four new _all_cddl targets - generate_bidi.py: remove hardcoded generate_permissions_file(); the permissions module is now fully driven by permissions-all.cddl - bidi_enhancements_manifest.py: add permissions enhancements restoring the high-level set_permission() API, including embeddedOrigin support that the old hardcoded version was missing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- generate_bidi.bzl: replace cat-based merge with a hermetic Python script written via ctx.actions.write + ctx.actions.run, fixing portability on Windows where cat is unavailable - bidi_enhancements_manifest.py: make embedded_origin keyword-only in set_permission() by moving it after user_context with a * separator, preserving the existing positional call signature (descriptor, state, origin, user_context) - bidi_permissions_tests.py: add two new tests: - test_embedded_origin_is_keyword_only: guards against regression of the positional API (4th arg must remain user_context, not embedded_origin) - test_can_set_permission_with_embedded_origin: exercises the embedded_origin keyword arg end-to-end, verifying embeddedOrigin serialization in the BiDi command params Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Replace the inline ctx.actions.write + hardcoded Python string in generate_bidi.bzl with a standalone py_binary, consistent with how the generator itself is wired up. - py/private/merge_cddl.py: new tool that concatenates CDDL files - py/private/BUILD.bazel: declare merge_cddl py_binary - py/private/generate_bidi.bzl: add merge_tool attr (executable, cfg=exec); drop ctx.actions.write — merge step is now a plain ctx.actions.run - py/BUILD.bazel: wire merge_tool = "//py/private:merge_cddl" Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- merge_cddl.py: add arg validation (usage + SystemExit(1) if < 2 args) and insert a newline separator between files to prevent token-joining - generate_bidi.bzl: make merge_tool optional (mandatory=False); add explicit fail() when extra_cddl_files is set without merge_tool - bidi_enhancements_manifest.py: drop spurious return from set_permission (annotated -> None, was returning execute() result) - bidi_permissions_tests.py: add pytest.raises(TypeError) for 5th positional arg in test_embedded_origin_is_keyword_only; fix test_can_set_permission_with_embedded_origin docstring to accurately describe what is tested Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

- generate_bidi.bzl: replace cat-based merge with a hermetic Python script written via ctx.actions.write + ctx.actions.run, fixing portability on Windows where cat is unavailable - bidi_enhancements_manifest.py: make embedded_origin keyword-only in set_permission() by moving it after user_context with a * separator, preserving the existing positional call signature (descriptor, state, origin, user_context) - bidi_permissions_tests.py: add two new tests: - test_embedded_origin_is_keyword_only: guards against regression of the positional API (4th arg must remain user_context, not embedded_origin) - test_can_set_permission_with_embedded_origin: exercises the embedded_origin keyword arg end-to-end, verifying embeddedOrigin serialization in the BiDi command params Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- merge_cddl.py: add arg validation (usage + SystemExit(1) if < 2 args) and insert a newline separator between files to prevent token-joining - generate_bidi.bzl: make merge_tool optional (mandatory=False); add explicit fail() when extra_cddl_files is set without merge_tool - bidi_enhancements_manifest.py: drop spurious return from set_permission (annotated -> None, was returning execute() result) - bidi_permissions_tests.py: add pytest.raises(TypeError) for 5th positional arg in test_embedded_origin_is_keyword_only; fix test_can_set_permission_with_embedded_origin docstring to accurately describe what is tested Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 23, 2026 19:49

selenium-ci added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Apr 23, 2026

Copilot started reviewing on behalf of AutomatedTester April 23, 2026 19:50 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread py/private/bidi_enhancements_manifest.py

Comment thread py/private/generate_bidi.bzl Outdated

Comment thread py/private/bidi_enhancements_manifest.py Outdated

Copilot AI review requested due to automatic review settings April 24, 2026 10:23

Copilot started reviewing on behalf of AutomatedTester April 24, 2026 10:23 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

AutomatedTester and others added 4 commits April 25, 2026 12:52

Copilot AI review requested due to automatic review settings April 25, 2026 11:53

AutomatedTester force-pushed the extend-bidi-features branch from 6c1f2aa to 9adba4b Compare April 25, 2026 11:53

Copilot started reviewing on behalf of AutomatedTester April 25, 2026 11:54 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

AutomatedTester merged commit b95cd1f into trunk Apr 27, 2026
41 of 42 checks passed

AutomatedTester deleted the extend-bidi-features branch April 27, 2026 08:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(py): extend create-bidi-src with full set of BiDi-adjacent CDDL …#17378

feat(py): extend create-bidi-src with full set of BiDi-adjacent CDDL …#17378
AutomatedTester merged 4 commits into
trunkfrom
extend-bidi-features

AutomatedTester commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

AutomatedTester commented Apr 23, 2026

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

🤖 AI assistance

💡 Additional Considerations

🔄 Types of changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants