Skip to content

[dotnet] Don't truncate internal log messages at error/warn levels #17333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 3 commits into from
Apr 10, 2026
+19 −2
Merged

[dotnet] Don't truncate internal log messages at error/warn levels #17333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b255465
[dotnet] Don't truncate internal log messages at error/warn levels
nvborisenko Apr 10, 2026
231c1e8
Optimize
nvborisenko Apr 10, 2026
dac78fd
Add tests
nvborisenko Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dotnet/src/webdriver/Internal/Logging/LogContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,12 @@ public void EmitMessage(ILogger logger, DateTimeOffset timestamp, LogEventLevel
{
if (IsEnabled(logger, level))
{
string truncatedMessage = TruncateMessage(message, _truncationLength);
if (_truncationLength.HasValue && level < LogEventLevel.Warn)
{
message = TruncateMessage(message, _truncationLength);
}
Comment thread
nvborisenko marked this conversation as resolved.

var logEvent = new LogEvent(logger.Issuer, timestamp, level, truncatedMessage);
var logEvent = new LogEvent(logger.Issuer, timestamp, level, message);
Comment thread
nvborisenko marked this conversation as resolved.
Comment thread
qodo-code-review[bot] marked this conversation as resolved.

foreach (var handler in Handlers)
{
Expand Down
14 changes: 14 additions & 0 deletions dotnet/test/webdriver/Internal/Logging/LogTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,20 @@ public void ShouldNotTruncateWhenDisabled()
Assert.That(testLogHandler.Events, Has.Count.EqualTo(1));
Assert.That(testLogHandler.Events[0].Message, Is.EqualTo(longMessage));
}

[TestCase(LogEventLevel.Warn)]
[TestCase(LogEventLevel.Error)]
public void ShouldNotTruncateImportantMessages(LogEventLevel level)
{
var longMessage = new string('a', 150);

using var context = Log.CreateContext(level).WithTruncation(100).Handlers.Add(testLogHandler);

logger.LogMessage(DateTimeOffset.Now, level, longMessage);

Assert.That(testLogHandler.Events, Has.Count.EqualTo(1));
Assert.That(testLogHandler.Events[0].Message, Is.EqualTo(longMessage));
}
}

internal class TestLogHandler : ILogHandler
Expand Down
Loading