Skip to content

[dotnet] [bidi] Add disposed guard #17161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 1 commit into from
Mar 2, 2026
Merged

[dotnet] [bidi] Add disposed guard #17161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dotnet/src/webdriver/BiDi/BiDi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ namespace OpenQA.Selenium.BiDi;
public sealed class BiDi : IBiDi
{
private readonly ConcurrentDictionary<Type, Module> _modules = new();
private bool _disposed;

private Broker Broker { get; set; } = null!;

Expand Down Expand Up @@ -83,6 +84,13 @@ public Task<EndResult> EndAsync(EndOptions? options = null, CancellationToken ca

public async ValueTask DisposeAsync()
{
if (_disposed)
{
return;
}

_disposed = true;

await Broker.DisposeAsync().ConfigureAwait(false);
GC.SuppressFinalize(this);
}
Comment thread
nvborisenko marked this conversation as resolved.
Expand Down
Loading