Skip to content

[java] Improve screenshot error message #17120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asolntsev merged 4 commits into from
Feb 25, 2026
Merged

[java] Improve screenshot error message #17120

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1ca731
Improve diagnostic message when screenshot file write fails
seethinajayadileep Feb 20, 2026
91c824b
Restore accidentally removed line
seethinajayadileep Feb 20, 2026
18ee9e7
Apply formatting
seethinajayadileep Feb 25, 2026
2979ff7
Refactor screenshot temp file creation error handling
seethinajayadileep Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions java/src/org/openqa/selenium/OutputType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,23 @@ public File convertFromPngBytes(byte[] data) {
}

private File save(byte[] data) {
Path tmpFilePath = null;
try {
Path tmpFilePath = Files.createTempFile("screenshot", ".png");
File tmpFile = tmpFilePath.toFile();
tmpFile.deleteOnExit();
tmpFilePath = Files.createTempFile("screenshot", ".png");
Files.write(tmpFilePath, data);
return tmpFile;
} catch (IOException e) {
throw new WebDriverException(e);
String pathInfo =
(tmpFilePath != null)
? tmpFilePath.toAbsolutePath().toString()
: "temporary file could not be created";

throw new WebDriverException(
"Failed to create or write screenshot to temporary file: " + pathInfo, e);
}

File tmpFile = tmpFilePath.toFile();
tmpFile.deleteOnExit();
return tmpFile;
}

public String toString() {
Expand Down
Loading