Skip to content

Replace hardcoded bazel-selenium references with dynamic path resolution #16976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 6 commits into from
Jan 22, 2026
Merged

Replace hardcoded bazel-selenium references with dynamic path resolution #16976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8b2b65
Replace hardcoded bazel-selenium references with dynamic path resolution
titusfortner Jan 22, 2026
d929637
Fix buildifier formatting
titusfortner Jan 22, 2026
204f8c3
Validate bazel output_base before constructing external path
titusfortner Jan 22, 2026
7554237
Fix EXEC_ROOT path resolution by following symlink before navigating
titusfortner Jan 22, 2026
d5dd302
Use bazel info execution_root for reliable path resolution
titusfortner Jan 22, 2026
bcd4a33
Keep bazel-selenium in README for readability
titusfortner Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,7 @@ rust/target
rust/.idea

# Bazel stuff
bazel-bin
bazel-genfiles
bazel-out
bazel-selenium
bazel-testlogs
/bazel-*
MODULE.bazel.lock

/.vscode/
Expand Down
12 changes: 8 additions & 4 deletions dotnet/private/docfx.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,18 @@ def _docfx_impl(ctx):
_UNIX_TEMPLATE = """#!/usr/bin/env bash
set -euo pipefail
cd "$BUILD_WORKSPACE_DIRECTORY"
exec "$BUILD_WORKSPACE_DIRECTORY/bazel-selenium/{dotnet}" exec \
"$BUILD_WORKSPACE_DIRECTORY/bazel-selenium/{docfx}" {config} "$@"
EXEC_ROOT=$(bazel info execution_root)
exec "$EXEC_ROOT/{dotnet}" exec \
"$EXEC_ROOT/{docfx}" {config} "$@"
"""

_WINDOWS_TEMPLATE = """@echo off
setlocal
cd /d "%BUILD_WORKSPACE_DIRECTORY%"
"%BUILD_WORKSPACE_DIRECTORY%\\bazel-selenium\\{dotnet}" exec ^
"%BUILD_WORKSPACE_DIRECTORY%\\bazel-selenium\\{docfx}" {config} %*
for /f "tokens=*" %%i in ('bazel info execution_root') do set "EXEC_ROOT=%%i"
"%EXEC_ROOT%\\{dotnet}" exec ^
"%EXEC_ROOT%\\{docfx}" {config} %*
endlocal
"""

docfx = rule(
Expand Down
8 changes: 6 additions & 2 deletions dotnet/update-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
REPO_ROOT="$SCRIPT_DIR/.."

if [[ -d "$REPO_ROOT/bazel-selenium/external" ]]; then
DOTNET_DIR=$(find "$REPO_ROOT/bazel-selenium/external" -maxdepth 1 -name "rules_dotnet++dotnet+dotnet_*" -type d | head -1)
OUTPUT_BASE=$(cd "$REPO_ROOT" && bazel info output_base 2>/dev/null)
if [[ -n "$OUTPUT_BASE" && -d "$OUTPUT_BASE/external" ]]; then
EXTERNAL_DIR="$OUTPUT_BASE/external"
DOTNET_DIR=$(find "$EXTERNAL_DIR" -maxdepth 1 -name "rules_dotnet++dotnet+dotnet_*" -type d 2>/dev/null | head -1)
if [[ -n "$DOTNET_DIR" && -x "$DOTNET_DIR/dotnet" ]]; then
DOTNET="$DOTNET_DIR/dotnet"
echo "Using bazel-managed dotnet: $DOTNET"
fi
else
echo "Warning: bazel info output_base failed; falling back to system dotnet" >&2
fi
DOTNET="${DOTNET:-dotnet}"

Expand Down