Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion py/selenium/webdriver/common/selenium_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from pathlib import Path

from selenium.common import WebDriverException
from selenium.webdriver import __version__ as VERSION

logger = logging.getLogger(__name__)

Expand All @@ -36,7 +37,7 @@ class SeleniumManager:
"""

def binary_paths(self, args: list) -> dict:
"""Determines the locations of the requested assets.
"""Builds the Selenium Manager command line argument list and runs it.

Args:
args: the commands to send to the selenium manager binary.
Expand All @@ -49,6 +50,8 @@ def binary_paths(self, args: list) -> dict:
args.append("--debug")
args.append("--language-binding")
args.append("python")
args.append("--selenium-version")
args.append(VERSION)
args.append("--output")
args.append("json")

Expand Down
10 changes: 9 additions & 1 deletion py/test/selenium/webdriver/common/selenium_manager_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,15 @@ def test_gets_results(monkeypatch):
SeleniumManager().binary_paths([])

mock_get_binary.assert_called_once()
expected_run_args = ["/path/to/sm", "--language-binding", "python", "--output", "json"]
expected_run_args = [
"/path/to/sm",
"--language-binding",
"python",
"--selenium-version",
selenium.__version__,
"--output",
"json",
]
mock_run.assert_called_once_with(expected_run_args)


Expand Down
Loading