Skip to content

Conversation

@bonigarcia
Copy link
Member

@bonigarcia bonigarcia commented Oct 24, 2025

User description

🔗 Related Issues

https://github.com/SeleniumHQ/selenium/actions/runs/18769300152/job/53551395345

💥 What does this PR do?

This PR fixes a Edge test in SM, broken due to an unavailable Edge version.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Replace unavailable Edge version with stable version

  • Fixes broken Edge version test in Selenium Manager


Diagram Walkthrough

flowchart LR
  A["Edge version test"] -- "Replace 137.0.3296.93" --> B["Use stable version"]
  B -- "Ensures test passes" --> C["CI pipeline succeeds"]
Loading

File Walkthrough

Relevant files
Bug fix
browser_download_tests.rs
Update Edge version test case to stable                                   

rust/tests/browser_download_tests.rs

  • Changed Edge test case from specific version 137.0.3296.93 to stable
  • Resolves test failure caused by unavailable Edge build
  • Maintains test coverage while using available version
+1/-1     

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Oct 24, 2025
@selenium-ci selenium-ci added the B-manager Selenium Manager label Oct 24, 2025
@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@bonigarcia bonigarcia merged commit 269608c into trunk Oct 24, 2025
31 checks passed
@bonigarcia bonigarcia deleted the sm_fix_edge_test branch October 24, 2025 12:59
This was referenced Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-manager Selenium Manager C-rust Rust code is mostly Selenium Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants