-
-
Couldn't load subscription status.
- Fork 8.6k
[rb] update syntax with rspec linter #16498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
User description
does not look like the rubocop-rspec linter is being run with our current bazel command. Need to track that down.
PR Type
Enhancement
Description
Standardize Ruby hash formatting in RSpec tests
Remove spaces around hash braces per rubocop-rspec linter
Reorganize hash key ordering for consistency
Fix incorrect file path in RuboCop configuration
Diagram Walkthrough
File Walkthrough
service_spec.rb
Standardize hash formatting in IE service specrb/spec/integration/selenium/webdriver/ie/service_spec.rb
describeblock hash parameters to remove spaces aroundbraces
excludebeforeexclusiveservice_spec.rb
Standardize hash formatting in Safari service specrb/spec/integration/selenium/webdriver/safari/service_spec.rb
describeblock hash parameters to remove spaces aroundbraces
excludebeforeexclusiveguards_spec.rb
Remove spaces in hash formatting throughout guards specrb/spec/unit/selenium/webdriver/guards_spec.rb
{condition: :guarded }to{condition: :guarded}).rubocop.yml
Fix incorrect file path in RuboCop configurationrb/.rubocop.yml
RSpec/NoExpectationExampleexclusionspec/integration/selenium/webdriver/guard_spec.rbtospec/unit/selenium/webdriver/guards_spec.rb