Skip to content

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 23, 2025

User description

Getting tab crashed errors with Chrome 142 on RBE
Copying the fix in Python from #16443


PR Type

Bug fix


Description

  • Disable /dev/shm usage for Chrome and Edge on RBE

  • Prevents tab crash errors with Chrome 142

  • Refactors argument passing to options hash


Diagram Walkthrough

flowchart LR
  A["Chrome/Edge Options"] -->|Add disable-dev-shm flag| B["RBE Environment"]
  B -->|Prevents tab crashes| C["Stable Chrome 142"]
Loading

File Walkthrough

Relevant files
Bug fix
test_environment.rb
Add dev-shm disable flag for Chrome/Edge on RBE                   

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

  • Added --disable-dev-shm-usage flag for Chrome and Edge when running on
    RBE
  • Refactored argument passing to use opts[:args] instead of direct args:
    parameter
  • Applied same fix to both chrome_options and edge_options methods
  • Prevents tab crash errors with Chrome 142 on RBE infrastructure
+6/-2     

@selenium-ci selenium-ci added the C-rb Ruby Bindings label Oct 23, 2025
@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Learned
best practice
Use local, validated predicate

Guard the RBE-specific flag with a precise and locally testable predicate (e.g.,
rbe?) and ensure the method exists or is referenced consistently to prevent
NameError or misrouting when the environment helper is absent.

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb [279]

-args << '--disable-dev-shm-usage' if GlobalTestEnv.rbe?
+args << '--disable-dev-shm-usage' if rbe?
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Validate inputs and states early to avoid logic errors; guard environment-specific flags behind precise, testable predicates.

Low
  • More

@titusfortner titusfortner merged commit 229e299 into trunk Oct 23, 2025
34 checks passed
@titusfortner titusfortner deleted the rb_dev_shm branch October 23, 2025 18:23
This was referenced Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants