-
-
Couldn't load subscription status.
- Fork 8.6k
[rb][build] improve ruby local_dev generation #16495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
User description
The
./go rb:local_devcommand is builds everything so that all assets/code that needs to be generated in the build process is created so that any tests that need to be run can be run through RubyMine instead of just bazel for better debugging options.I have my RubyMine set to use the ruby binary stored in the bazel-selenium working directory.
For local Ruby development, if you want to run on RBE, you have to switch to jruby, and every time you change the ruby versions, RubyMine gets unhappy. Running
./go rb:local_devshould fix this, but for some reason it builds the ruby binary, but does not stage it in thebazel-selenium/ working directory. Adding a command that requires using the ruby binary forces it to be staged.PR Type
Enhancement
Description
Adds informative message during Ruby binary installation
Executes additional Bazel command to stage Ruby binary
Ensures Ruby binary is properly placed in working directory
Diagram Walkthrough
File Walkthrough
Rakefile
Add Ruby binary staging to local_dev taskRakefile
--dry-runflag for rubocop to forcestaging of Ruby binary
command