[py]: close ipv6 port in case of error

[navin772]

User description

🔗 Related Issues

Fixes #16164

💥 What does this PR do?

Prevents socket leak in case of error when ipv6 connection fails in the free_port method.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix

---

Description

• Fix socket leak in IPv6 connection error handling

• Add proper socket cleanup in free_port method

---

Diagram Walkthrough

flowchart LR
  A["IPv4 bind fails"] --> B["Try IPv6 bind"]
  B --> C["IPv6 bind fails"]
  C --> D["Close IPv6 socket"]
  D --> E["Raise RuntimeError"]

Loading

File Walkthrough

	Relevant files
Bug fix	utils.py Add IPv6 socket cleanup on error                                                  py/selenium/webdriver/common/utils.py Add socket cleanup in IPv6 error handling path Prevent socket leak when IPv6 binding fails +2/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 1234 - Partially compliant Compliant requirements: None Non-compliant requirements: Investigate regression for JavaScript-in-href click not triggering in 2.48.x on Firefox. Provide fix or workaround for the click behavior regression. Validate behavior on specified Firefox version/environment. Requires further human verification: Reproduce and manually validate alert triggering behavior across specified Selenium/Firefox versions. 5678 - Partially compliant Compliant requirements: None Non-compliant requirements: Diagnose and resolve ConnectFailure when creating multiple ChromeDriver instances. Ensure reliable multi-instance ChromeDriver startup. Provide validation steps confirming resolution. Requires further human verification: Environment-specific validation on Ubuntu 16.04.4 with Chrome/ChromeDriver versions mentioned.

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue If IPv6 bind succeeds but later operations fail, the socket may remain open; consider using context management or finally blocks to guarantee closure for all paths. try: free_socket = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) free_socket.bind(("::1", 0)) except OSError: if free_socket: free_socket.close() raise RuntimeError("Can't find free port (Unable to bind to IPv4 or IPv6)") try: port: int = free_socket.getsockname()[1] except Exception as e: Robustness When IPv6 bind fails, closing the socket after a failed bind may be redundant but safe; consider setting the socket to None post-close to avoid double-close risks if code changes later. if free_socket: free_socket.close() raise RuntimeError("Can't find free port (Unable to bind to IPv4 or IPv6)")

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Reset variable after closing socket Ensure free_socket is reset to None after closing it to avoid accidentally using a closed socket in later code paths. This prevents potential misuse if the variable is referenced after a failed bind. It also makes the intent explicit that the resource is no longer valid. py/selenium/webdriver/common/utils.py [39-49] except OSError: if free_socket: free_socket.close() + free_socket = None # IPv6 try: free_socket = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) free_socket.bind(("::1", 0)) except OSError: if free_socket: free_socket.close() + free_socket = None raise RuntimeError("Can't find free port (Unable to bind to IPv4 or IPv6)") [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 3 __ Why: The suggestion to set free_socket to None after closing is a good practice, but in this context, its impact is minimal as the variable is either immediately reassigned or the function exits via a raise.	Low
Update

[cgoldberg]

LGTM