Skip to content

[java] Add @Nullable annotations to InternetExplorerDriverService parameters #16001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

[java] Add @Nullable annotations to InternetExplorerDriverService parameters #16001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e928a0
Add @Nullable annotations to InternetExplorerDriverService parameters
iampopovich Jul 5, 2025
5a499d2
Merge branch 'trunk' into feat-14291/jspecify-nullable-annotation_iex…
diemol Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions java/src/org/openqa/selenium/ie/InternetExplorerDriverService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
import org.jspecify.annotations.Nullable;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.WebDriverException;
import org.openqa.selenium.remote.service.DriverFinder;
Expand Down Expand Up @@ -78,11 +79,11 @@ public class InternetExplorerDriverService extends DriverService {
* @throws IOException If an I/O error occurs.
*/
public InternetExplorerDriverService(
File executable,
@Nullable File executable,
int port,
Duration timeout,
List<String> args,
Map<String, String> environment)
@Nullable Duration timeout,
@Nullable List<String> args,
@Nullable Map<String, String> environment)
throws IOException {
super(
executable,
Expand Down Expand Up @@ -128,10 +129,10 @@ public static class Builder
extends DriverService.Builder<
InternetExplorerDriverService, InternetExplorerDriverService.Builder> {

private InternetExplorerDriverLogLevel logLevel;
private String host = null;
private File extractPath = null;
private Boolean silent = null;
private @Nullable InternetExplorerDriverLogLevel logLevel;
private @Nullable String host = null;
private @Nullable File extractPath = null;
private @Nullable Boolean silent = null;

@Override
public int score(Capabilities capabilities) {
Expand All @@ -154,7 +155,7 @@ public int score(Capabilities capabilities) {
* @param logLevel A level of the log verbosity.
* @return A self reference.
*/
public Builder withLogLevel(InternetExplorerDriverLogLevel logLevel) {
public Builder withLogLevel(@Nullable InternetExplorerDriverLogLevel logLevel) {
this.logLevel = logLevel;
return this;
}
Expand All @@ -165,7 +166,7 @@ public Builder withLogLevel(InternetExplorerDriverLogLevel logLevel) {
* @param host A host name.
* @return A self reference.
*/
public Builder withHost(String host) {
public Builder withHost(@Nullable String host) {
this.host = host;
return this;
}
Expand All @@ -176,7 +177,7 @@ public Builder withHost(String host) {
* @param extractPath A path.
* @return A self reference.
*/
public Builder withExtractPath(File extractPath) {
public Builder withExtractPath(@Nullable File extractPath) {
this.extractPath = extractPath;
return this;
}
Expand All @@ -187,7 +188,7 @@ public Builder withExtractPath(File extractPath) {
* @param silent To be silent in stdout or not.
* @return A self reference.
*/
public Builder withSilent(Boolean silent) {
public Builder withSilent(@Nullable Boolean silent) {
this.silent = silent;
return this;
}
Expand Down Expand Up @@ -244,7 +245,11 @@ protected List<String> createArgs() {

@Override
protected InternetExplorerDriverService createDriverService(
File exe, int port, Duration timeout, List<String> args, Map<String, String> environment) {
@Nullable File exe,
int port,
@Nullable Duration timeout,
@Nullable List<String> args,
@Nullable Map<String, String> environment) {
try {
return new InternetExplorerDriverService(exe, port, timeout, args, environment);
} catch (IOException e) {
Expand Down