-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Fix failing test for Edge logging #15605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Fix failing test for Edge logging #15605
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
User description
💥 What does this PR do?
This is a fix to the internal Python test suite.
This PR fixes the test_uses_edgedriver_logging test in py/test/selenium/webdriver/edge/edge_service_tests.py.
Previously, this test was failing because it was attempting to launch 2 browsers using the same Service object. This is not possible and results in an error:
This PR creates 2 Service objects so each driver instance can use its own.
🔄 Types of changes
PR Type
Bug fix
Description
Fixed failing
test_uses_edgedriver_loggingin Edge service tests.Replaced single
Serviceobject with two separate instances.Ensured proper cleanup of driver instances and log file.
Changes walkthrough 📝
edge_service_tests.py
Fix Edge logging test with separate Service instancespy/test/selenium/webdriver/edge/edge_service_tests.py
Serviceobject with two separate instances.driver1to avoid potential errors.