[dotnet] [bidi] Decouple nested types in Locator

[nvborisenko]

User description

Motivation and Context

Contributes to #15407

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Decoupled nested DTO types into standalone types for better flexibility.

• Replaced nested types like AccessibilityLocatorValue with independent records.

• Introduced new standalone types: AccessibilityValue, ContextValue, and MatchType.

• Improved maintainability and future extensibility of locator-related classes.

---

Changes walkthrough 📝

	Relevant files
Enhancement	Locator.cs Decoupled nested DTO types into standalone records              dotnet/src/webdriver/BiDi/Modules/BrowsingContext/Locator.cs Replaced nested DTO types with standalone records. Added AccessibilityValue and ContextValue as independent records. Introduced MatchType enum for InnerTextLocator. Simplified and decoupled locator-related class definitions. +17/-19

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15407 - Fully compliant Compliant requirements: Decoupled nested DTO types in Locator classes Replaced nested types with standalone types Implemented the specific example of using CssLocator instead of Locator.Css

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Serialization Attribute The new standalone types (AccessibilityValue, ContextValue) and enum (MatchType) may need JsonDerivedType attributes for proper serialization/deserialization, similar to how they were handled in the nested types. public enum MatchType { Full, Partial }

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add JSON property mapping Update the InnerTextLocator class to use the JsonPropertyName attribute for the MatchType property to ensure proper serialization with the BiDi protocol, which expects "match" as the property name. dotnet/src/webdriver/BiDi/Modules/BrowsingContext/Locator.cs [38-45] public record InnerTextLocator(string Value) : Locator { public bool? IgnoreCase { get; set; } + [JsonPropertyName("match")] public MatchType? MatchType { get; set; } public long? MaxDepth { get; set; } } Apply this suggestion Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a potential serialization issue with the BiDi protocol. Adding the JsonPropertyName attribute ensures the MatchType property will be properly serialized as "match" in JSON, which is critical for protocol compatibility. This is an important fix that prevents potential runtime errors.	Medium
Learned best practice	Initialize nullable properties with meaningful default values to improve code clarity and prevent potential null reference issues The InnerTextLocator record has nullable properties without default values. Consider initializing these properties with meaningful default values in the constructor to improve code clarity and prevent potential null reference issues. dotnet/src/webdriver/BiDi/Modules/BrowsingContext/Locator.cs [38-45] public record InnerTextLocator(string Value) : Locator { - public bool? IgnoreCase { get; set; } + public bool? IgnoreCase { get; set; } = false; - public MatchType? MatchType { get; set; } + public MatchType? MatchType { get; set; } = MatchType.Full; - public long? MaxDepth { get; set; } + public long? MaxDepth { get; set; } = null; } Apply this suggestion Suggestion importance[1-10]: 6	Low
More