-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] Fix BiDi tests errors #15482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Fix BiDi tests errors #15482
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Fix BiDi tests errors
User description
Motivation and Context
We want our tests to be executed and pass for the BiDi implementation
This PR aims to fix the browser_context and network bidi tests
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fixed BiDi tests for browser context and network.
Updated error handling for unknown types in tests.
Improved handling of user prompts in browsing context tests.
Added cleanup step to reset driver in network tests.
Changes walkthrough 📝
browsing_context_spec.rb
Fix and enhance browsing context BiDi testsrb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
driverwithbridgefor browsing context initialization.network_spec.rb
Enhance network BiDi tests with cleanuprb/spec/integration/selenium/webdriver/bidi/network_spec.rb