Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Update Jruby to version 9.4.9.0 #14791

Merged
merged 12 commits into from
Jan 11, 2025

Conversation

aguspe
Copy link
Contributor

@aguspe aguspe commented Nov 22, 2024

Description

This PR focuses on upgrading the existing Ruby version from 9.4.5.0 for Selenium to 9.4.9.0

Motivation and Context

In April 2025 Ruby 3.1 will reach the end of life as shown here: https://endoflife.date/ruby

Ruby 3.2.2 is the minimum 3.2 version with security patches and bug fixes built on top of the 3.2.0 Ruby version, besides Ruby 3.2 support extends until March 2026

To be able to upgrade to Ruby 3.2.x and keep our pipeline compatibility with Jruby we need to be prepare to update to Jruby 10

3.2.2 Release: https://www.ruby-lang.org/en/news/2023/03/30/ruby-3-2-2-released/

State of Jruby 10: jruby/jruby#7517

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement, configuration changes


Description

  • Updated the required Ruby version across multiple configuration files from 3.1 to 3.2.
  • Modified the version specification for the 'steep' gem in the Gemfile.
  • Ensured consistency in Ruby versioning across the project files.

Changes walkthrough 📝

Relevant files
Enhancement
selenium-devtools.gemspec
Update required Ruby version in gemspec                                   

rb/selenium-devtools.gemspec

  • Updated the required Ruby version from 3.1 to 3.2.
+1/-1     
Configuration changes
.rubocop.yml
Update target Ruby version in RuboCop configuration           

rb/.rubocop.yml

  • Updated the target Ruby version from 3.1 to 3.2.
+1/-1     
.ruby-version
Update Ruby version file                                                                 

rb/.ruby-version

  • Updated the Ruby version from 3.1.6 to 3.2.2.
+1/-1     
Gemfile
Modify 'steep' gem version specification                                 

rb/Gemfile

  • Changed the version specification for the 'steep' gem to '~> 1.5.0'.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Conflict
    The file appears to contain both versions 3.2.2 and 3.1.6 on separate lines, which could cause version conflicts. Only one version should be specified.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 22, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    ✅ Remove duplicate version specification to prevent version ambiguity
    Suggestion Impact:The commit changes the Ruby version, but in the opposite direction of the suggestion - it replaces 3.2.2 with 3.1.6 instead of removing 3.1.6

    code diff:

    -3.2.2
    +3.1.6

    Remove the duplicate '3.1.6' line from the .ruby-version file as it creates
    ambiguity about which version should be used.

    rb/.ruby-version [1-2]

     +3.2.2
    - 3.1.6
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Having two different Ruby versions (3.2.2 and 3.1.6) in the .ruby-version file is a critical issue that could cause version conflicts and inconsistent behavior across different environments. The duplicate line should be removed to maintain a single, clear version specification.

    9

    💡 Need additional feedback ? start a PR chat

    @aguspe aguspe changed the title Update ruby version [rb] Update ruby version to 3.2.2 Nov 22, 2024
    @aguspe aguspe added the C-rb label Nov 22, 2024
    @aguspe aguspe changed the title [rb] Update ruby version to 3.2.2 [rb] Update Jruby to version 9.4.9.0 Jan 6, 2025
    @aguspe aguspe requested a review from p0deje January 8, 2025 20:34
    Copy link
    Member

    @p0deje p0deje left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    You need to also bump the ruby-version parameter inside .github/workflows

    MODULE.bazel Outdated Show resolved Hide resolved
    @aguspe aguspe merged commit e4b1e48 into SeleniumHQ:trunk Jan 11, 2025
    23 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants