[dotnet] Propagate async throughout test setup and teardown #14775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Propagates
async
all the way to the top (where NUnit handles it) instead ofGetAwaiter().GetResult()
Motivation and Context
Sync-over-async makes for bulkier code. It also prevents future
SuppressThrowing
optimizations.Types of changes
Checklist
PR Type
enhancement, tests
Description
EnvironmentManager
,RemoteSeleniumServer
, andTestWebServer
.Changes walkthrough 📝
11 files
ChromeSpecificTests.cs
Convert Chrome test teardown to async
dotnet/test/chrome/ChromeSpecificTests.cs
async
keyword toRunAfterAnyTests
method.StopAsync
.AssemblyFixture.cs
Update AssemblyFixture setup and teardown to async
dotnet/test/common/AssemblyFixture.cs
async
keyword to setup and teardown methods.EnvironmentManager.cs
Use async stop methods in EnvironmentManager destructor
dotnet/test/common/Environment/EnvironmentManager.cs
RemoteSeleniumServer.cs
Convert RemoteSeleniumServer start and stop to async
dotnet/test/common/Environment/RemoteSeleniumServer.cs
Start
andStop
methods to async.TestWebServer.cs
Convert TestWebServer start and stop to async
dotnet/test/common/Environment/TestWebServer.cs
Start
andStop
methods to async.AssemblyTeardown.cs
Update Edge assembly setup and teardown to async
dotnet/test/edge/AssemblyTeardown.cs
async
keyword to setup and teardown methods.StopAsync
.AssemblyTeardown.cs
Update Firefox assembly setup and teardown to async
dotnet/test/firefox/AssemblyTeardown.cs
async
keyword to setup and teardown methods.StopAsync
.AssemblyTeardown.cs
Update IE assembly setup and teardown to async
dotnet/test/ie/AssemblyTeardown.cs
async
keyword to setup and teardown methods.StopAsync
.AssemblyTeardown.cs
Update Remote assembly setup and teardown to async
dotnet/test/remote/AssemblyTeardown.cs
async
keyword to setup and teardown methods.PopupWindowFinderTest.cs
Update PopupWindowFinderTest setup and teardown to async
dotnet/test/support/UI/PopupWindowFinderTest.cs
async
keyword to setup and teardown methods.StopAsync
.SelectBrowserTests.cs
Update SelectBrowserTests setup and teardown to async
dotnet/test/support/UI/SelectBrowserTests.cs
async
keyword to setup and teardown methods.StopAsync
.