-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] detect a client timeout while session creation #14743 #14756
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit 26a9f94)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
3af493d
to
26a9f94
Compare
User description
Description
This PR will ensure a client timeout will not lead to a session waiting for the session timeout.
The timeout check has been removed from the complete method, to return the session as long as the client is still listening for the response.
Motivation and Context
Does fix #14743
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Changes walkthrough 📝
LocalDistributor.java
Improve session validation and termination logic
java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
LocalNewSessionQueue.java
Enhance session cancellation and completion logic
java/src/org/openqa/selenium/grid/sessionqueue/local/LocalNewSessionQueue.java
DistributedTest.java
Add test for client timeout handling in distributed grid
java/test/org/openqa/selenium/grid/router/DistributedTest.java
BUILD.bazel
Update Bazel build to include new distributed test
java/test/org/openqa/selenium/grid/router/BUILD.bazel
DistributedTest.java
in the list of large tests.