Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][py] Update latest index for new Nightly upload #14739

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Nov 10, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Nightly build upload to TestPyPi is marked as Pre-release, so when install via pip install -i https://test.pypi.org/simple/selenium, it doesn't actually install the latest Nightly.
When referring to few answer, they mentioned something like

When uploading a package to TestPyPi, the version is marked as pre-release if the version number includes a pre-release identifier (e.g., 1.0.0-alpha, 1.0.0-beta, 1.0.0-rc1). To ensure that your package is marked as the latest release, you need to use a version number that does not include any pre-release identifiers.
The version prefix 4.27.0.nightly202410311942 indicates a nightly build, which is typically considered a pre-release. To ensure your package is marked as the latest release on TestPyPi, you should use a version number without any pre-release identifiers. If you want to use a nightly build version but still mark it as the latest, you can use a versioning scheme that does not include terms like nightly. For example, you could use 4.27.0.202410311942.

So, the versioning scheme doesn't include any terms to make every upload should be updated as latest
For example: https://test.pypi.org/project/selenium/#history, https://test.pypi.org/project/selenium/#description - it navigates to the latest version and pip install command updated accordingly.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement


Description

  • Updated the versioning scheme across multiple files to remove pre-release identifiers, ensuring the nightly builds are recognized as the latest release.
  • Changes affect the documentation, Selenium initialization files, setup configuration, Rakefile, and Bazel build configuration.

Changes walkthrough 📝

Relevant files
Enhancement
conf.py
Update release version format in documentation                     

py/docs/source/conf.py

  • Updated the release version format to remove pre-release identifiers.
  • +1/-1     
    __init__.py
    Modify version format in Selenium init file                           

    py/selenium/init.py

  • Changed the __version__ format to remove pre-release identifiers.
  • +1/-1     
    __init__.py
    Adjust version format in WebDriver init file                         

    py/selenium/webdriver/init.py

  • Updated the __version__ format to remove pre-release identifiers.
  • +1/-1     
    setup.py
    Change version format in setup configuration                         

    py/setup.py

    • Altered the version format to exclude pre-release identifiers.
    +1/-1     
    Rakefile
    Update nightly version pattern in Rakefile                             

    Rakefile

  • Modified the nightly version pattern to exclude pre-release
    identifiers.
  • +2/-2     
    BUILD.bazel
    Revise version format in Bazel build configuration             

    py/BUILD.bazel

  • Updated the Selenium version format to remove pre-release identifiers.

  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 10, 2024

    PR Reviewer Guide 🔍

    (Review updated until commit 911245f)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Pattern Change
    The updated regex pattern for version matching now includes '\d{12}' which may match unintended version strings. Verify this change doesn't affect other version parsing logic.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 10, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Improve version pattern matching precision by adding word boundaries to prevent unintended matches

    The updated regex pattern for version matching should be anchored to the end of the
    string with $ to prevent partial matches. Also consider adding word boundaries \b to
    prevent matching within larger numbers.

    Rakefile [1141]

    -pattern = /-?\.?(nightly|SNAPSHOT|dev|\d{12})\d*$/
    +pattern = /-?\.?(nightly|SNAPSHOT|dev|\b\d{12}\b)\d*$/
    • Apply this suggestion
    Suggestion importance[1-10]: 4

    Why: The suggestion to add word boundaries (\b) to the regex pattern is valid and can help prevent potential edge cases in version matching, though the current pattern is already sufficiently functional with the end anchor ($) in place.

    4

    💡 Need additional feedback ? start a PR chat

    @VietND96 VietND96 requested a review from diemol November 10, 2024 21:23
    @VietND96 VietND96 changed the title [py] Update latest index for new Nightly upload [ci][py] Update latest index for new Nightly upload Nov 10, 2024
    @VietND96 VietND96 force-pushed the py-nightly branch 2 times, most recently from 08ceab9 to d646594 Compare November 10, 2024 21:59
    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 10, 2024

    CI Failure Feedback 🧐

    (Checks updated until commit 5678b5d)

    Action: Ruby / Local Tests (chrome, windows) / Local Tests (chrome, windows)

    Failed stage: Run Bazel [❌]

    Failed test name: Selenium::WebDriver::Chrome::Driver PrintsPage

    Failure summary:

    The action failed because the test Selenium::WebDriver::Chrome::Driver PrintsPage encountered
    multiple failures due to timeout errors. Specifically:

  • The test returns base64 for print command failed with a Selenium::WebDriver::Error::TimeoutError
    indicating a timeout while receiving a message from the renderer.
  • The test prints with valid params also failed with a Selenium::WebDriver::Error::TimeoutError for
    the same reason.
  • The test saves pdf failed similarly with a Selenium::WebDriver::Error::TimeoutError.
    These failures
    suggest that the tests were unable to complete within the expected time frame, possibly due to
    performance issues or misconfigurations in the test environment.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Microsoft Windows Server 2022
    ...
    
    531:  �[32m[1 / 1]�[0m checking cached actions
    532:  �[32mAnalyzing:�[0m 31 targets (363 packages loaded, 43662 targets configured)
    533:  �[32m[1 / 21]�[0m [Prepa] Writing repo mapping manifest for //rb/spec/integration/selenium/webdriver:zipper-chrome
    534:  �[32mINFO: �[0mAnalyzed 31 targets (363 packages loaded, 43662 targets configured).
    535:  �[32m[8 / 27]�[0m Creating source manifest for //rb/spec/integration/selenium/webdriver:bidi-chrome; 0s local ... ( 1 action running)
    536:  �[32m[16 / 43]�[0m Creating source manifest for //rb/spec/integration/selenium/webdriver:devtools-chrome; 0s local ... (2 actions, 1 running)
    537:  �[32m[127 / 1,156]�[0m [Prepa] Creating source manifest for //rb/spec/integration/selenium/webdriver/remote:driver-chrome ... (3 actions, 1 running)
    538:  �[32m[419 / 1,449]�[0m Creating source manifest for //rb/spec/integration/selenium/webdriver:guard-chrome; 0s local ... (4 actions running)
    539:  �[32m[833 / 1,848]�[0m [Prepa] Creating source manifest for //rb/spec/integration/selenium/webdriver:error-chrome ... (2 actions, 1 running)
    ...
    
    799:  �[32m[1,879 / 1,900]�[0m 4 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 12s disk-cache ... (4 actions, 2 running)
    800:  �[32m[1,880 / 1,900]�[0m 5 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 14s disk-cache ... (4 actions, 1 running)
    801:  �[32m[1,880 / 1,900]�[0m 5 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/remote:driver-chrome; 11s disk-cache ... (4 actions, 1 running)
    802:  �[32m[1,880 / 1,900]�[0m 5 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/remote:driver-chrome; 18s disk-cache ... (4 actions, 1 running)
    803:  �[32m[1,880 / 1,900]�[0m 5 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/remote:driver-chrome; 20s disk-cache ... (4 actions, 2 running)
    804:  �[32m[1,881 / 1,900]�[0m 6 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 14s disk-cache ... (4 actions, 1 running)
    805:  �[32m[1,881 / 1,900]�[0m 6 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 19s disk-cache ... (4 actions, 2 running)
    806:  �[32m[1,882 / 1,900]�[0m 7 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 20s disk-cache ... (4 actions, 1 running)
    807:  �[32m[1,882 / 1,900]�[0m 7 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 8s disk-cache ... (4 actions, 1 running)
    808:  �[32m[1,882 / 1,900]�[0m 7 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 10s disk-cache ... (4 actions, 2 running)
    809:  �[32m[1,883 / 1,900]�[0m 8 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 11s disk-cache ... (4 actions, 1 running)
    810:  �[32m[1,883 / 1,900]�[0m 8 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 20s disk-cache ... (4 actions, 1 running)
    811:  �[32m[1,884 / 1,900]�[0m 9 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 22s disk-cache ... (4 actions, 0 running)
    ...
    
    864:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 325s local, disk-cache ... (4 actions, 1 running)
    865:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 335s local, disk-cache ... (4 actions, 1 running)
    866:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 336s local, disk-cache ... (4 actions, 1 running)
    867:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 340s local, disk-cache ... (4 actions, 1 running)
    868:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 366s local, disk-cache ... (4 actions, 1 running)
    869:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 426s local, disk-cache ... (4 actions, 1 running)
    870:  �[32m[1,896 / 1,900]�[0m 21 / 31 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 454s local, disk-cache ... (4 actions, 2 running)
    871:  �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver/chrome:driver-chrome (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/chrome/driver-chrome/test.log)
    872:  �[31m�[1mFAILED: �[0m//rb/spec/integration/selenium/webdriver/chrome:driver-chrome (Summary)
    ...
    
    887:  gets and sets network conditions
    888:  sets download path
    889:  can execute CDP commands
    890:  manages network features
    891:  casts
    892:  can set single permissions
    893:  can set multiple permissions
    894:  PrintsPage
    895:  returns base64 for print command (FAILED - 1)
    896:  prints with valid params (FAILED - 2)
    897:  saves pdf (FAILED - 3)
    898:  #logs
    899:  can fetch available log types
    900:  can get the browser log
    901:  can get the driver log
    902:  can get the performance log
    903:  Failures:
    904:  1) Selenium::WebDriver::Chrome::Driver PrintsPage returns base64 for print command
    905:  Failure/Error: expect(driver.print_page).to include(magic_number)
    906:  Selenium::WebDriver::Error::TimeoutError:
    907:  timeout: Timed out receiving message from renderer: 10.000
    908:  (Session info: chrome=131.0.6778.85)
    909:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    910:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    915:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    916:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    917:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    918:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    919:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    920:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:67:in `block (3 levels) in <module:Chrome>'
    921:  # ------------------
    922:  # --- Caused by: ---
    923:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    941:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    942:  (No symbol) [0x00007FF7133AEB5F]
    943:  (No symbol) [0x00007FF7133AA814]
    944:  (No symbol) [0x00007FF7133AA9AD]
    945:  (No symbol) [0x00007FF71339A199]
    946:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    947:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    948:  2) Selenium::WebDriver::Chrome::Driver PrintsPage prints with valid params
    949:  Failure/Error:
    950:  expect(driver.print_page(orientation: 'landscape',
    951:  page_ranges: ['1-2'],
    952:  page: {width: 30})).to include(magic_number)
    953:  Selenium::WebDriver::Error::TimeoutError:
    954:  timeout: Timed out receiving message from renderer: 10.000
    955:  (Session info: chrome=131.0.6778.85)
    956:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    957:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    962:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    963:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    964:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    965:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    966:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    967:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:72:in `block (3 levels) in <module:Chrome>'
    968:  # ------------------
    969:  # --- Caused by: ---
    970:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    988:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    989:  (No symbol) [0x00007FF7133AEB5F]
    990:  (No symbol) [0x00007FF7133AA814]
    991:  (No symbol) [0x00007FF7133AA9AD]
    992:  (No symbol) [0x00007FF71339A199]
    993:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    994:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    995:  3) Selenium::WebDriver::Chrome::Driver PrintsPage saves pdf
    996:  Failure/Error: driver.save_print_page path
    997:  Selenium::WebDriver::Error::TimeoutError:
    998:  timeout: Timed out receiving message from renderer: 10.000
    999:  (Session info: chrome=131.0.6778.85)
    1000:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1001:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1009:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1010:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1011:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:37:in `block in save_print_page'
    1012:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `open'
    1013:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `save_print_page'
    1014:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:82:in `block (3 levels) in <module:Chrome>'
    1015:  # ------------------
    1016:  # --- Caused by: ---
    1017:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1035:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1036:  (No symbol) [0x00007FF7133AEB5F]
    1037:  (No symbol) [0x00007FF7133AA814]
    1038:  (No symbol) [0x00007FF7133AA9AD]
    1039:  (No symbol) [0x00007FF71339A199]
    1040:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1041:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1042:  Finished in 2 minutes 7.4 seconds (files took 1.34 seconds to load)
    1043:  14 examples, 3 failures
    1044:  Failed examples:
    ...
    
    1059:  gets and sets network conditions
    1060:  sets download path
    1061:  can execute CDP commands
    1062:  manages network features
    1063:  casts
    1064:  can set single permissions
    1065:  can set multiple permissions
    1066:  PrintsPage
    1067:  returns base64 for print command (FAILED - 1)
    1068:  prints with valid params (FAILED - 2)
    1069:  saves pdf (FAILED - 3)
    1070:  #logs
    1071:  can fetch available log types
    1072:  can get the browser log
    1073:  can get the driver log
    1074:  can get the performance log
    1075:  Failures:
    1076:  1) Selenium::WebDriver::Chrome::Driver PrintsPage returns base64 for print command
    1077:  Failure/Error: expect(driver.print_page).to include(magic_number)
    1078:  Selenium::WebDriver::Error::TimeoutError:
    1079:  timeout: Timed out receiving message from renderer: 10.000
    1080:  (Session info: chrome=131.0.6778.85)
    1081:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1082:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1087:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    1088:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    1089:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    1090:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1091:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1092:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:67:in `block (3 levels) in <module:Chrome>'
    1093:  # ------------------
    1094:  # --- Caused by: ---
    1095:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1113:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1114:  (No symbol) [0x00007FF7133AEB5F]
    1115:  (No symbol) [0x00007FF7133AA814]
    1116:  (No symbol) [0x00007FF7133AA9AD]
    1117:  (No symbol) [0x00007FF71339A199]
    1118:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1119:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1120:  2) Selenium::WebDriver::Chrome::Driver PrintsPage prints with valid params
    1121:  Failure/Error:
    1122:  expect(driver.print_page(orientation: 'landscape',
    1123:  page_ranges: ['1-2'],
    1124:  page: {width: 30})).to include(magic_number)
    1125:  Selenium::WebDriver::Error::TimeoutError:
    1126:  timeout: Timed out receiving message from renderer: 10.000
    1127:  (Session info: chrome=131.0.6778.85)
    1128:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1129:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1134:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    1135:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    1136:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    1137:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1138:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1139:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:72:in `block (3 levels) in <module:Chrome>'
    1140:  # ------------------
    1141:  # --- Caused by: ---
    1142:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1160:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1161:  (No symbol) [0x00007FF7133AEB5F]
    1162:  (No symbol) [0x00007FF7133AA814]
    1163:  (No symbol) [0x00007FF7133AA9AD]
    1164:  (No symbol) [0x00007FF71339A199]
    1165:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1166:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1167:  3) Selenium::WebDriver::Chrome::Driver PrintsPage saves pdf
    1168:  Failure/Error: driver.save_print_page path
    1169:  Selenium::WebDriver::Error::TimeoutError:
    1170:  timeout: Timed out receiving message from renderer: 10.000
    1171:  (Session info: chrome=131.0.6778.85)
    1172:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1173:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1181:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1182:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1183:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:37:in `block in save_print_page'
    1184:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `open'
    1185:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `save_print_page'
    1186:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:82:in `block (3 levels) in <module:Chrome>'
    1187:  # ------------------
    1188:  # --- Caused by: ---
    1189:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1207:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1208:  (No symbol) [0x00007FF7133AEB5F]
    1209:  (No symbol) [0x00007FF7133AA814]
    1210:  (No symbol) [0x00007FF7133AA9AD]
    1211:  (No symbol) [0x00007FF71339A199]
    1212:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1213:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1214:  Finished in 2 minutes 7.4 seconds (files took 1.32 seconds to load)
    1215:  14 examples, 3 failures
    1216:  Failed examples:
    ...
    
    1231:  gets and sets network conditions
    1232:  sets download path
    1233:  can execute CDP commands
    1234:  manages network features
    1235:  casts
    1236:  can set single permissions
    1237:  can set multiple permissions
    1238:  PrintsPage
    1239:  returns base64 for print command (FAILED - 1)
    1240:  prints with valid params (FAILED - 2)
    1241:  saves pdf (FAILED - 3)
    1242:  #logs
    1243:  can fetch available log types
    1244:  can get the browser log
    1245:  can get the driver log
    1246:  can get the performance log
    1247:  Failures:
    1248:  1) Selenium::WebDriver::Chrome::Driver PrintsPage returns base64 for print command
    1249:  Failure/Error: expect(driver.print_page).to include(magic_number)
    1250:  Selenium::WebDriver::Error::TimeoutError:
    1251:  timeout: Timed out receiving message from renderer: 10.000
    1252:  (Session info: chrome=131.0.6778.85)
    1253:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1254:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1259:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    1260:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    1261:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    1262:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1263:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1264:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:67:in `block (3 levels) in <module:Chrome>'
    1265:  # ------------------
    1266:  # --- Caused by: ---
    1267:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1285:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1286:  (No symbol) [0x00007FF7133AEB5F]
    1287:  (No symbol) [0x00007FF7133AA814]
    1288:  (No symbol) [0x00007FF7133AA9AD]
    1289:  (No symbol) [0x00007FF71339A199]
    1290:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1291:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1292:  2) Selenium::WebDriver::Chrome::Driver PrintsPage prints with valid params
    1293:  Failure/Error:
    1294:  expect(driver.print_page(orientation: 'landscape',
    1295:  page_ranges: ['1-2'],
    1296:  page: {width: 30})).to include(magic_number)
    1297:  Selenium::WebDriver::Error::TimeoutError:
    1298:  timeout: Timed out receiving message from renderer: 10.000
    1299:  (Session info: chrome=131.0.6778.85)
    1300:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1301:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1306:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    1307:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    1308:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:685:in `execute'
    1309:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1310:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1311:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:72:in `block (3 levels) in <module:Chrome>'
    1312:  # ------------------
    1313:  # --- Caused by: ---
    1314:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1332:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1333:  (No symbol) [0x00007FF7133AEB5F]
    1334:  (No symbol) [0x00007FF7133AA814]
    1335:  (No symbol) [0x00007FF7133AA9AD]
    1336:  (No symbol) [0x00007FF71339A199]
    1337:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1338:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1339:  3) Selenium::WebDriver::Chrome::Driver PrintsPage saves pdf
    1340:  Failure/Error: driver.save_print_page path
    1341:  Selenium::WebDriver::Error::TimeoutError:
    1342:  timeout: Timed out receiving message from renderer: 10.000
    1343:  (Session info: chrome=131.0.6778.85)
    1344:  # ./rb/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    1345:  # ./rb/lib/selenium/webdriver/remote/response.rb:41:in `error'
    ...
    
    1353:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:421:in `print_page'
    1354:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:54:in `print_page'
    1355:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:37:in `block in save_print_page'
    1356:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `open'
    1357:  # ./rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb:36:in `save_print_page'
    1358:  # ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:82:in `block (3 levels) in <module:Chrome>'
    1359:  # ------------------
    1360:  # --- Caused by: ---
    1361:  # Selenium::WebDriver::Error::WebDriverError:
    ...
    
    1379:  GetHandleVerifier [0x00007FF7134FBDBB+835995]
    1380:  (No symbol) [0x00007FF7133AEB5F]
    1381:  (No symbol) [0x00007FF7133AA814]
    1382:  (No symbol) [0x00007FF7133AA9AD]
    1383:  (No symbol) [0x00007FF71339A199]
    1384:  BaseThreadInitThunk [0x00007FF9D0234CB0+16]
    1385:  RtlUserThreadStart [0x00007FF9D10DECDB+43]
    1386:  Finished in 2 minutes 7.2 seconds (files took 1.17 seconds to load)
    1387:  14 examples, 3 failures
    1388:  Failed examples:
    1389:  rspec ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:65 # Selenium::WebDriver::Chrome::Driver PrintsPage returns base64 for print command
    1390:  rspec ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:70 # Selenium::WebDriver::Chrome::Driver PrintsPage prints with valid params
    1391:  rspec ./rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb:77 # Selenium::WebDriver::Chrome::Driver PrintsPage saves pdf
    1392:  ================================================================================
    1393:  �[32m[1,897 / 1,900]�[0m 22 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:navigation-chrome; 121s ... (3 actions, 1 running)
    1394:  �[32m[1,897 / 1,900]�[0m 22 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:driver-chrome; 119s ... (3 actions, 2 running)
    1395:  �[32m[1,898 / 1,900]�[0m 23 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:driver-chrome; 120s ... (2 actions, 1 running)
    1396:  �[32m[1,898 / 1,900]�[0m 23 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:navigation-chrome; 4s local, disk-cache ... (2 actions running)
    1397:  �[32m[1,899 / 1,900]�[0m 24 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:driver-chrome; 1s local, disk-cache
    1398:  �[32m[1,899 / 1,900]�[0m 24 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:driver-chrome; 11s local, disk-cache
    1399:  �[32m[1,899 / 1,900]�[0m 24 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:driver-chrome; 15s local, disk-cache
    1400:  �[32m[1,900 / 1,901]�[0m 25 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:script-chrome; 0s disk-cache
    1401:  �[32m[1,900 / 1,901]�[0m 25 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:script-chrome
    1402:  �[32m[1,900 / 1,901]�[0m 25 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:script-chrome; 1s local, disk-cache
    1403:  �[32m[1,900 / 1,901]�[0m 25 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:script-chrome; 3s local, disk-cache
    1404:  �[32m[1,901 / 1,902]�[0m 26 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 0s disk-cache
    1405:  �[32m[1,901 / 1,902]�[0m 26 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:bidi-chrome
    1406:  �[32m[1,901 / 1,902]�[0m 26 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 1s local, disk-cache
    1407:  �[32m[1,901 / 1,902]�[0m 26 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 3s local, disk-cache
    1408:  �[32m[1,902 / 1,903]�[0m 27 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome; 0s disk-cache
    1409:  �[32m[1,902 / 1,903]�[0m 27 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome
    1410:  �[32m[1,902 / 1,903]�[0m 27 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome; 1s local, disk-cache
    1411:  �[32m[1,902 / 1,903]�[0m 27 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome; 3s local, disk-cache
    1412:  �[32m[1,903 / 1,904]�[0m 28 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:network-chrome; 0s disk-cache
    1413:  �[32m[1,903 / 1,904]�[0m 28 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:network-chrome
    1414:  �[32m[1,903 / 1,904]�[0m 28 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:network-chrome; 1s local, disk-cache
    1415:  �[32m[1,903 / 1,904]�[0m 28 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:network-chrome; 3s local, disk-cache
    1416:  �[32m[1,904 / 1,905]�[0m 29 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-chrome; 0s disk-cache
    1417:  �[32m[1,904 / 1,905]�[0m 29 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:devtools-chrome
    1418:  �[32m[1,904 / 1,905]�[0m 29 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-chrome; 1s local, disk-cache
    1419:  �[32m[1,904 / 1,905]�[0m 29 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-chrome; 137s local, disk-cache
    1420:  �[32m[1,905 / 1,906]�[0m 30 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 0s disk-cache
    1421:  �[32m[1,905 / 1,906]�[0m 30 / 31 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome
    1422:  �[32m[1,905 / 1,906]�[0m 30 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 1s local, disk-cache
    1423:  �[32m[1,905 / 1,906]�[0m 30 / 31 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 3s local, disk-cache
    1424:  �[32mINFO: �[0mFound 31 test targets...
    1425:  �[32mINFO: �[0mElapsed time: 1569.384s, Critical Path: 914.93s
    1426:  �[32mINFO: �[0m1906 processes: 796 disk cache hit, 845 internal, 265 local.
    1427:  �[32mINFO: �[0mBuild completed, 1 test FAILED, 1906 total actions
    1428:  //rb/spec/integration/selenium/webdriver:action_builder-chrome           �[0m�[32mPASSED�[0m in 16.1s
    1429:  //rb/spec/integration/selenium/webdriver:bidi-chrome                     �[0m�[32mPASSED�[0m in 3.7s
    1430:  //rb/spec/integration/selenium/webdriver:devtools-chrome                 �[0m�[32mPASSED�[0m in 137.6s
    1431:  //rb/spec/integration/selenium/webdriver:driver-chrome                   �[0m�[32mPASSED�[0m in 15.6s
    1432:  //rb/spec/integration/selenium/webdriver:element-chrome                  �[0m�[32mPASSED�[0m in 16.9s
    1433:  //rb/spec/integration/selenium/webdriver:error-chrome                    �[0m�[32mPASSED�[0m in 7.4s
    ...
    
    1450:  //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome       �[0m�[32mPASSED�[0m in 3.7s
    1451:  //rb/spec/integration/selenium/webdriver/bidi:network-chrome             �[0m�[32mPASSED�[0m in 3.7s
    1452:  //rb/spec/integration/selenium/webdriver/bidi:script-chrome              �[0m�[32mPASSED�[0m in 3.6s
    1453:  //rb/spec/integration/selenium/webdriver/chrome:options-chrome           �[0m�[32mPASSED�[0m in 10.0s
    1454:  //rb/spec/integration/selenium/webdriver/chrome:profile-chrome           �[0m�[32mPASSED�[0m in 5.9s
    1455:  //rb/spec/integration/selenium/webdriver/chrome:service-chrome           �[0m�[32mPASSED�[0m in 7.9s
    1456:  //rb/spec/integration/selenium/webdriver/remote:driver-chrome            �[0m�[32mPASSED�[0m in 5.1s
    1457:  //rb/spec/integration/selenium/webdriver/remote:element-chrome           �[0m�[32mPASSED�[0m in 9.0s
    1458:  //rb/spec/integration/selenium/webdriver/chrome:driver-chrome            �[0m�[31m�[1mFAILED�[0m in 3 out of 3 in 130.7s
    1459:  Stats over 3 runs: max = 130.7s, min = 130.3s, avg = 130.5s, dev = 0.2s
    1460:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/chrome/driver-chrome/test.log
    1461:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/chrome/driver-chrome/test_attempts/attempt_1.log
    1462:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/chrome/driver-chrome/test_attempts/attempt_2.log
    1463:  Executed 31 out of 31 tests: 30 tests pass and �[0m�[31m�[1m1 fails locally�[0m.
    1464:  There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
    1465:  �[0m
    1466:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @VietND96 VietND96 force-pushed the py-nightly branch 2 times, most recently from d3adc09 to 0b85cee Compare November 10, 2024 23:44
    @VietND96 VietND96 marked this pull request as draft November 11, 2024 03:36
    @VietND96 VietND96 force-pushed the py-nightly branch 2 times, most recently from 0cc9230 to 651ddd2 Compare November 19, 2024 11:51
    @VietND96 VietND96 marked this pull request as ready for review November 19, 2024 14:55
    Copy link
    Contributor

    Persistent review updated to latest commit 911245f

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Improve version pattern matching precision by adding word boundaries to prevent unintended matches

    The updated regex pattern for version matching should be anchored to the end of the
    string with $ to prevent partial matches. Also consider adding word boundaries \b to
    prevent matching within larger numbers.

    Rakefile [1141]

    -pattern = /-?\.?(nightly|SNAPSHOT|dev|\d{12})\d*$/
    +pattern = /-?\.?(nightly|SNAPSHOT|dev|\b\d{12}\b)\d*$/
    • Apply this suggestion
    Suggestion importance[1-10]: 4

    Why: The suggestion to add word boundaries (\b) to the regex pattern is valid and can help prevent potential edge cases in version matching, though the current pattern is already sufficiently functional with the end anchor ($) in place.

    4

    💡 Need additional feedback ? start a PR chat

    @VietND96 VietND96 merged commit 789e8d4 into trunk Nov 20, 2024
    28 of 31 checks passed
    @VietND96 VietND96 deleted the py-nightly branch November 20, 2024 10:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant