-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Fix TypeError when init Safari webdriver #14699
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Has this fix landed in any release? https://github.com/SeleniumHQ/selenium/releases |
FYI, Chrome early stable release will comes out, we also will do a minor release next week including this fix. https://chromiumdash.appspot.com/schedule |
waiting for this fix to come out soon. I see this error in py 3.12.7 / 3.13. Let me check quickly in 3.11 |
I think Python version is not a problem, you can try to pin selenium==4.25.0 in the meantime. |
Pinning to |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
TypeError
in the Safari WebDriver initialization by removing theClientConfig
and adjusting theSafariRemoteConnection
setup.test_launch_safari_with_legacy_flag
as skipped, indicating it needs updates.Changes walkthrough 📝
webdriver.py
Fix TypeError by adjusting SafariRemoteConnection initialization
py/selenium/webdriver/safari/webdriver.py
ClientConfig
import and usage.SafariRemoteConnection
initialization to directly useparameters.
launcher_tests.py
Mark Safari legacy flag test to be skipped
py/test/selenium/webdriver/safari/launcher_tests.py
test_launch_safari_with_legacy_flag
.ci-python.yml
Add Safari tests to CI workflow
.github/workflows/ci-python.yml