-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] Set session-request-timeout as client readTimeout in RemoteNewSessionQueue #14272
Conversation
…SessionQueue Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #14272 +/- ##
==========================================
+ Coverage 57.18% 57.46% +0.28%
==========================================
Files 89 89
Lines 5514 5549 +35
Branches 232 228 -4
==========================================
+ Hits 3153 3189 +36
- Misses 2129 2132 +3
+ Partials 232 228 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, thank you, @VietND96!
…SessionQueue (SeleniumHQ#14272) Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
[grid] Set session-request-timeout as client readTimeout in RemoteNewSessionQueue
Motivation and Context
In CI tests for Selenium Grid autoscaling on K8s in repo https://github.com/SeleniumHQ/docker-selenium. Sometime could see below error even set
--session-request-timeout
over the default300
secondsI suspect that is due to timeout in HTTP client created by default config. So in this change, get
session-request-timeout
and set it as read timeout for HTTP client in RemoteNewSessionQueueCan you also review the change is able to resolve the problem mentioned in #13718?
Types of changes
Checklist
PR Type
Enhancement
Description
RemoteNewSessionQueue
to set the session-request-timeout as the client readTimeout.ClientConfig
andDuration
) to support the new functionality.create
method to includesessionRequestTimeout
and configure theHttpClient
accordingly.Changes walkthrough 📝
RemoteNewSessionQueue.java
Set session-request-timeout as client readTimeout in
RemoteNewSessionQueue
java/src/org/openqa/selenium/grid/sessionqueue/remote/RemoteNewSessionQueue.java
ClientConfig
andDuration
classes.sessionRequestTimeout
toRemoteNewSessionQueue.create
method.HttpClient
withsessionRequestTimeout
usingClientConfig
.