-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Update selenium manager types #14189
Conversation
…m manager commands
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
@titusfortner I saw the update you did on the selenium manager class, so I changed my PR to add the right types and update the correspondent RBS file for the selenium manager class |
Hello @p0deje I hope you are having a great evening, whenever you have time could you review this PR? thank you for all your help |
Hi, sorry for delay. Can you please take a look at the CI failures? |
…nium into rb_leverage_streaming_output
Thank you so for taking the time, and no problem I know you are busy. Now I remove the last updates on arguments so this PR just updates the types after the changes done to the selenium manager class |
@aguspe Can you please take a look at linter failures? https://github.com/SeleniumHQ/selenium/actions/runs/9828809475/job/27218278086?pr=14189 |
@p0deje the linter issues are fixed now and only the RBS file is left |
Thank you! |
Co-authored-by: aguspe <[email protected]>
User description
Description
This PR adds the correct type after the Selenium manager class has been updated for ruby
Motivation and Context
It's important as described here #13989 that we utilize the new options available for us in the Selenium manager implementation and that we update the respective types
Types of changes
Checklist
PR Type
Enhancement
Description
--log-level debug
for better logging control.Changes walkthrough 📝
selenium_manager.rb
Update Selenium manager command options for Ruby client
rb/lib/selenium/webdriver/common/selenium_manager.rb