-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] allow a DevTools listener to determinate the order of handler calls #13921
Conversation
PR Description updated to latest commit (71606c3)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
CI Failure Feedback 🧐(Checks updated until commit 24e0ee8)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
71606c3
to
58edab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joerg1985!
…calls (SeleniumHQ#13921) Co-authored-by: Diego Molina <[email protected]>
User description
Description
This PR will allow to determinate the order of handler calls to handle chunked responses.
Motivation and Context
A possible solution for #13845
Types of changes
Checklist
PR Type
enhancement
Description
Connection
class to allow determination of the order of handler calls.eventCallbacks
map to useBiConsumer
allowing handlers to receive a sequence number along with the event data.addListener
method inDevTools
that supports sequence numbers, providing more control over event handling.Changes walkthrough 📝
Connection.java
Enhance event handling with sequence tracking
java/src/org/openqa/selenium/devtools/Connection.java
BiConsumer
import andNEXT_SEQUENCE
atomic long for trackingevent sequence.
eventCallbacks
to useBiConsumer
instead ofConsumer
.addListener
andhandle
methods to support event sequencing.DevTools.java
Add sequence-aware event listeners in DevTools
java/src/org/openqa/selenium/devtools/DevTools.java
BiConsumer
import.addListener
method to handle events with sequencenumbers.
addListener
method.