-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid][java]: apply protocol version in relay session factory #13880
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Description updated to latest commit (eed2f81)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @VietND96!
@diemol probably the fork in an org and something restricted that I can't remove. Anyhow, I just rebased the branch |
…umHQ#13880) Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
A missing in part of last PR #13849 for a workaround in the relay node with Appium
To ensure the fix works, I set up an end2end test where able to execute and verify the session can be created successfully based on the dev package built locally. Result as below
Tested TOML
Types of changes
Checklist
Type
Bug fix
Description
serviceProtocolVersion
was not being applied to theclientConfig
inRelaySessionFactory
.serviceProtocolVersion
is provided, it is set in theclientConfig
which is used to create a new session.Changes walkthrough
RelaySessionFactory.java
Apply Protocol Version in RelaySessionFactory
java/src/org/openqa/selenium/grid/node/relay/RelaySessionFactory.java
serviceProtocolVersion
toclientConfig
if it is not empty.