-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] flatten combined routes to improve routing #13856
Conversation
PR Description updated to latest commit (bf2b165)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit 11a8093)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
bf2b165
to
4e705b7
Compare
4e705b7
to
deef6fb
Compare
deef6fb
to
dada703
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13856 +/- ##
=======================================
Coverage 58.72% 58.72%
=======================================
Files 86 86
Lines 5298 5298
Branches 226 226
=======================================
Hits 3111 3111
Misses 1961 1961
Partials 226 226 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joerg1985!
Co-authored-by: Diego Molina <[email protected]>
User description
Motivation and Context
Before this PR there are 3 - 4 levels of nested
CombinedRoute
instances, this PR will flatten them.A
CombinedRoute
must callmatch
again insidehandle
to determinate the correctRoute
to call.Each
match
call will create a copy of theHttpRequest
to check this, this overhead is reduced by this PR.Types of changes
Checklist
Type
enhancement
Description
CombinedRoute
to flatten nested instances, improving the routing process by reducing the overhead of matching routes.CombinedRoute
instances.Changes walkthrough
Route.java
Refactor CombinedRoute to Flatten Nested Instances
java/src/org/openqa/selenium/remote/http/Route.java
ArrayList
.rawPrefixes
initialization fromLinkedList
toCollections.emptyList()
.CombinedRoute
constructor to flatten nestedCombinedRoute
instances and reverse their order.
RouteTest.java
Update Tests to Reflect Flattened Route Logic
java/test/org/openqa/selenium/remote/http/RouteTest.java
Route.combine
to reflect changes inflattening logic.