-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid][java]: session-timeout set connection timeout in RemoteNode #13854
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
@diemol, can you also review this one? |
PR Description updated to latest commit (63872ee)
|
PR Review(Review updated until commit 2eac37a)
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Description updated to latest commit (2eac37a)
|
Persistent review updated to latest commit 2eac37a |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
@VietND96 can you please update your fork? |
Signed-off-by: Viet Nguyen Duc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the fork.
@diemol, I updated the fork. Also, I found that the test is used to define a CustomNode, and it can be added. So, I updated the CustomNode with attr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13854 +/- ##
=======================================
Coverage 58.70% 58.70%
=======================================
Files 86 86
Lines 5296 5296
Branches 226 226
=======================================
Hits 3109 3109
Misses 1961 1961
Partials 226 226 ☔ View full report in Codecov by Sentry. |
…eleniumHQ#13854) * [grid][java]: add session-timeout to all kind of Nodes Signed-off-by: Viet Nguyen Duc <[email protected]> * [grid][java]: fix code as suggestions Signed-off-by: Viet Nguyen Duc <[email protected]> * [java][grid]: update test CustomNode can get/set sessionTimeout Signed-off-by: Viet Nguyen Duc <[email protected]> --------- Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Try something for #13340
session-timeout
is an attribute of all node types and can get in part ofNodeStatus
Use
session-timeout
to set connection timeout and read timeout for HttpClient config inRemoteNode
Types of changes
Checklist
Type
enhancement
Description
sessionTimeout
toNodeStatus
and updated JSON handling.sessionTimeout
.sessionTimeout
in node configurations and assertions.Changes walkthrough
9 files
NodeStatus.java
Add session timeout to NodeStatus
java/src/org/openqa/selenium/grid/data/NodeStatus.java
sessionTimeout
field toNodeStatus
class.sessionTimeout
.AddNode.java
Include session timeout in node creation
java/src/org/openqa/selenium/grid/distributor/AddNode.java
execute
method to includesessionTimeout
when creating a newnode.
GridModel.java
Handle session timeout in GridModel
java/src/org/openqa/selenium/grid/distributor/GridModel.java
rewrite
andamend
methods to handlesessionTimeout
.LocalDistributor.java
Adjust node registration to include session timeout
java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
register
method to includesessionTimeout
in node creation.Node.java
Add session timeout management in Node base class
java/src/org/openqa/selenium/grid/node/Node.java
sessionTimeout
to the Node class and updated constructors.sessionTimeout
.OneShotNode.java
Manage session timeout in OneShotNode
java/src/org/openqa/selenium/grid/node/k8s/OneShotNode.java
sessionTimeout
in the constructor and during node creation.LocalNode.java
Update LocalNode to handle session timeout
java/src/org/openqa/selenium/grid/node/local/LocalNode.java
sessionTimeout
.RemoteNode.java
Enhance RemoteNode with session timeout configuration
java/src/org/openqa/selenium/grid/node/remote/RemoteNode.java
sessionTimeout
.sessionTimeout
for read timeout.GridRedisClient.java
Include session timeout in Redis client node retrieval
java/src/org/openqa/selenium/redis/GridRedisClient.java
getNode
method to includesessionTimeout
in the node status.4 files
NodeStatusTest.java
Update NodeStatus tests to include session timeout
java/test/org/openqa/selenium/grid/data/NodeStatusTest.java
sessionTimeout
inNodeStatus
.AddingNodesTest.java
Update distributor tests for session timeout handling
java/test/org/openqa/selenium/grid/distributor/AddingNodesTest.java
sessionTimeout
in node status events andstatus retrieval.
DefaultSlotSelectorTest.java
Update slot selector tests to include session timeout
java/test/org/openqa/selenium/grid/distributor/selector/DefaultSlotSelectorTest.java
sessionTimeout
.NodeTest.java
Update Node tests to handle session timeout
java/test/org/openqa/selenium/grid/node/NodeTest.java
sessionTimeout
.