-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bidi][java] Add storage module #13675
Conversation
PR Description updated to latest commit (af9754f)
|
PR Review
✨ Review tool usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13675 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 86 86
Lines 5270 5270
Branches 220 220
=======================================
Hits 3082 3082
Misses 1968 1968
Partials 220 220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pujagani!
I think we need to land it and iterate over it when needed.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add storage module as described in https://w3c.github.io/webdriver-bidi/#module-storage
Motivation and Context
Implementing BiDi APIs incrementally
Types of changes
Checklist
Type
enhancement, tests
Description
Storage
class with methods for cookie management, including getting, setting, and deleting cookies.Cookie
class.BrowsingContextPartitionDescriptor
,CookieFilter
, and more.storage
package and its tests.Changes walkthrough
Storage.java
Implement Storage Class with Cookie Management Methods
java/src/org/openqa/selenium/bidi/Storage.java
Storage
class to handle storage-related commands.BiDi
protocol for communication.BytesValue.java
Update Visibility of BytesValue Components
java/src/org/openqa/selenium/bidi/network/BytesValue.java
Type
enum and constructor ofBytesValue
public.*.java
Add Storage Module Supporting Classes
java/src/org/openqa/selenium/bidi/storage/*.java
and partition management.
BrowsingContextPartitionDescriptor
,CookieFilter
,DeleteCookiesParameters
,GetCookiesParameters
,GetCookiesResult
,PartialCookie
,PartitionDescriptor
,PartitionKey
,SetCookieParameters
,and
StorageKeyPartitionDescriptor
.Cookie.java
Fix Cookie JSON Property Names and Expiry Handling
java/src/org/openqa/selenium/bidi/network/Cookie.java
httpOnly
cookies.Optional
.StorageCommandsTest.java
Add Tests for Storage Module Cookie Operations
java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java
set, and delete operations.
adding cookies, and deleting cookies.
BUILD.bazel
Update Bazel Build to Include Storage Package
java/src/org/openqa/selenium/bidi/BUILD.bazel
storage
package.BUILD.bazel
Add Bazel Build Configuration for Storage Module Tests
java/test/org/openqa/selenium/bidi/storage/BUILD.bazel