-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Update ring and required crates for riscv support #13194
Conversation
Selenium-webdriver fails to compile on RISC-V due to outdated version of ring used (https://bugs.gentoo.org/918098). Ring has added RISC-V support in briansmith/ring#1627, so update ring and additional necessary crates to allow us to build on RISC-V. This change was compile tested inside a virtual machine.
The lockfile should be auto generated, don't we need to change something in another file to ensure this is used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the Cargo.lock
is automatically updated by Cargo when there is some change in Cargo.toml
. So, I don't see the point of updating the lock file individually. In summary, I think this PR is incomplete or incorrect.
I understand now, since ring is indirect dependency here it needs to be fixed in the source of package which is actually depending on ring. Apologies for jumping to conclusion that it should be changed in selenium, I will close this PR. |
I suspect we can require a different version of a transitive dependency, depending on how it is set up? It just needs to be in a different file. |
The dependency chain goes like this: selenium -> reqwest -> hyper-rustls -> rustls -> ring and the culprit seems to be hyper-rustls; it doesn't use the latest version of rustls which pulls in the correct version of ring that compiles on risc-v. |
@AutomatedTester or @bonigarcia can you comment on how transitive rust dependencies work? |
There is plenty of online information about that: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html |
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
The test suites for gbenchmark, hypothesis, libopus, sh, and tornado time out. httplib2's test suite indirectly depends on selenium, which doesn't build on RISC-V. SeleniumHQ/selenium#13194 The other disabled test suites fail for various cryptic reasons.
Cargo.lock: Update ring and required crates for riscv support
Description
Selenium-webdriver fails to compile on RISC-V due to outdated version of ring used (https://bugs.gentoo.org/918098).
Ring has added RISC-V support in
briansmith/ring#1627, so update ring and additional necessary crates to allow us to build on RISC-V. This change was compile tested inside a virtual machine.
Types of changes
Checklist