Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] improve warning when CDP version not found #12880

Merged
merged 4 commits into from
Oct 6, 2023
Merged

[java] improve warning when CDP version not found #12880

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6f237c
[java] improve warning when CDP version not found
titusfortner Oct 5, 2023
ef49cbb
Update java/src/org/openqa/selenium/devtools/CdpVersionFinder.java
diemol Oct 6, 2023
9fcd976
Merge branch 'trunk' into cdp_warning
diemol Oct 6, 2023
bd6567d
fix linting issues
titusfortner Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions java/src/org/openqa/selenium/devtools/CdpVersionFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ private Optional<CdpInfo> findNearestMatch(int version) {
} else {
LOG.log(
Level.WARNING,
"Unable to find an exact match for CDP version {0}, so returning the closest version"
+ " found: {1}",
"Unable to find an exact match for CDP version {0}, returning the closest version; "
+ "found: {1}; "
+ "Please update to a Selenium version that supports CDP version {0}",
new Object[] {version, nearestMatch.getMajorVersion()});
}

Expand Down
Loading