Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Format dotnet code according to default config #12879

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Oct 5, 2023

Description

Fix small linter issues in dotnet/src folder.

Motivation and Context

Keep code "clean".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Member

Looks good. Is there a linting tool for this?

@titusfortner titusfortner added this to the 4.14 milestone Oct 6, 2023
@nvborisenko
Copy link
Member Author

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-format

dotnet-format is a code formatter for dotnet that applies style preferences to a project or solution. Preferences will be read from an .editorconfig file, if present, otherwise a default set of preferences will be used. At this time dotnet-format is able to format C# and Visual Basic projects with a subset of supported .editorconfig options.

@titusfortner
Copy link
Member

Hmm, it isn't working on my machine, does it need Windows?
Can we add a linting job to our CI like we have in other languages?

@nvborisenko
Copy link
Member Author

It doesn't require Windows.

Many things, which are supposed to work, don't work on this solution out of the box...

@titusfortner
Copy link
Member

What did you have to do to get it working?

@titusfortner titusfortner merged commit c04e433 into SeleniumHQ:trunk Oct 6, 2023
14 checks passed
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
@nvborisenko nvborisenko deleted the dotnet-format branch November 28, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants