Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangling log_output in Service #12871

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix dangling log_output in Service #12871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/common/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
import typing
from abc import ABC
from abc import abstractmethod
from io import IOBase
from platform import system
from subprocess import PIPE
from time import sleep
from typing import TextIO
from urllib import request
from urllib.error import URLError

Expand Down Expand Up @@ -136,7 +136,7 @@ def stop(self) -> None:
"""Stops the service."""

if self.log_output != PIPE:
if isinstance(self.log_output, TextIO):
if isinstance(self.log_output, IOBase):
self.log_output.close()
elif isinstance(self.log_output, int):
os.close(self.log_output)
Expand Down
Loading