Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing out logging on quit #12637

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Closing out logging on quit #12637

merged 4 commits into from
Sep 16, 2023
+7 −8

Commits on Sep 16, 2023

  1. Update webdriver to close geckodrive log_output process on quit

    @Sean-Gomez @titusfortner
    Sean-Gomez authored and titusfortner committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    5b22c56 View commit details
    Browse the repository at this point in the history

  2. Fixing syntax of log output close line in Python Firefox webdriver code

    @Sean-Gomez @titusfortner
    Sean-Gomez authored and titusfortner committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    da98de2 View commit details
    Browse the repository at this point in the history

  3. add conditional to close log_output whether it be type int or if it's… 

    … a file-like object
    @Sean-Gomez @titusfortner
    Sean-Gomez authored and titusfortner committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    75ed01f View commit details
    Browse the repository at this point in the history

  4. [py] move closing logic to common driver

    @titusfortner
    titusfortner committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0eab6cb View commit details
    Browse the repository at this point in the history