Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix Proxy Breaking in RemoteWebDriver #12607

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

KrishnaSuravarapu
Copy link
Contributor

@KrishnaSuravarapu KrishnaSuravarapu commented Aug 24, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #12475

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@KrishnaSuravarapu KrishnaSuravarapu changed the title Chore: Fix Proxy Breaking in RemoteWebDriver [java] Fix Proxy Breaking in RemoteWebDriver Aug 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc5509b) 57.01% compared to head (be051be) 57.01%.
Report is 4 commits behind head on trunk.

❗ Current head be051be differs from pull request most recent head 87e4ce0. Consider uploading reports for the commit 87e4ce0 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12607   +/-   ##
=======================================
  Coverage   57.01%   57.01%           
=======================================
  Files          86       86           
  Lines        5335     5335           
  Branches      198      198           
=======================================
  Hits         3042     3042           
  Misses       2095     2095           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @KrishnaSuravarapu!

@diemol diemol merged commit 181f9c3 into SeleniumHQ:trunk Aug 28, 2023
2 of 3 checks passed
@fpoort
Copy link

fpoort commented Aug 29, 2023

When will we have a patch / release with this fix?

@diemol
Copy link
Member

diemol commented Aug 29, 2023

This week.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Setting a Proxy when using RemoteWebdriver does not start the session
5 participants